-
Notifications
You must be signed in to change notification settings - Fork 13
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
torchtext end-of-life and broken #829
Comments
Yikes, I guess we should have followed up on the deprecation warning earlier ;) |
Spacy, a dependency of DIANNA already, may provide both functionalities. Looking at their code, it seems so. I came across a |
As a temporary fix to get CI green again, torch version is pinned in #841. Once this issue is resolved, the temporary fix can be removed. |
Removes dependency on deprecated torchtext (refs #829)
As noted in #827 and other recent PRs with breaking CI workflows, the torchtext package seems to be breaking down. It is no longer being developed (see pytorch/text#2250).
Some options:
Option 3 seems the most attractive to me, naively, but I haven't looked deeply into how unique the functionality is that we use. We only use torchtext in two ways:
from torchtext.data import get_tokenizer
inutils/tokenizer.py
from torchtext.vocab import Vectors
intest/utils.py
, in a couple of notebooks and in the dashboard.Can these easily be replaced? If not, a fourth option presents itself:
The text was updated successfully, but these errors were encountered: