Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix misspelled apply_export_overrides method #2306

Merged

Conversation

juliohq
Copy link
Contributor

@juliohq juliohq commented Jun 24, 2024

Fixes #2305.

The _apply_export_overrides method is called by apply_export_overrides, though the latter is misspelled and cannot be called by apply_scene_export_overrides (in DialogicUtil.gd) since it checks if the method exists before calling it.

@Jowan-Spooner
Copy link
Member

Omg, thanks, what a silly mistake.

@Jowan-Spooner Jowan-Spooner merged commit 509b254 into dialogic-godot:main Jun 24, 2024
2 checks passed
@juliohq juliohq deleted the fix-apply-export-overrides branch June 24, 2024 18:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

Default layout base _apply_export_overrides isn't called
2 participants