Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Default layout base _apply_export_overrides isn't called #2305

Closed
juliohq opened this issue Jun 24, 2024 · 2 comments · Fixed by #2306
Closed

Default layout base _apply_export_overrides isn't called #2305

juliohq opened this issue Jun 24, 2024 · 2 comments · Fixed by #2306
Labels
Bug 🐞 Something isn't working Planned This will be worked on soon

Comments

@juliohq
Copy link
Contributor

juliohq commented Jun 24, 2024

The problem

Describe the bug
Apparently _apply_export_overrides isn't called for default layout base. The script is located in res://addons/dialogic/Modules/DefaultLayoutParts/Base_Default/default_layout_base.gd.

To Reproduce
Steps to reproduce the behavior:

  1. Go to default_layout_base.gd script
  2. Add any print statement like print(true)
  3. Run the game and notice that the print statement isn't reached

Expected behavior
_apply_export_overrides should be called in order to apply the settings provided.

Screenshots
N/A

System (please complete the following information):

  • OS: Arch Linux
  • Godot Version: v4.2.2-stable
  • Dialogic Version: main branch

Solutions

Workaround

N/A

Possible fixes

N/A

@juliohq
Copy link
Contributor Author

juliohq commented Jun 24, 2024

Closing it right now as that was my mistake. I was using a different base layer scene.

@juliohq juliohq closed this as completed Jun 24, 2024
@juliohq
Copy link
Contributor Author

juliohq commented Jun 24, 2024

I'm sorry, actually that is indeed a bug as I have res://addons/dialogic/Modules/DefaultLayoutParts/Base_Default/default_layout_base.gd attached to the root base scene:

image

@juliohq juliohq reopened this Jun 24, 2024
@Jowan-Spooner Jowan-Spooner added Bug 🐞 Something isn't working Planned This will be worked on soon labels Jun 24, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug 🐞 Something isn't working Planned This will be worked on soon
Development

Successfully merging a pull request may close this issue.

2 participants