chore: upgrade @dhis2/prop-types to v3 #750
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
🚀 Deployed on https://pr-750--dhis2-ui.netlify.app |
|
Test summary
Run details
View run in Cypress Dashboard ➡️ This comment has been generated by cypress-bot as a result of this project's GitHub integration settings. You can manage this integration in this project's settings in the Cypress Dashboard |
HendrikThePendric
force-pushed
the
chore/upgrade-to-prop-types-v3
branch
from
61a3aeb
to
0938658
Compare
HendrikThePendric
force-pushed
the
chore/upgrade-to-prop-types-v3
branch
from
0938658
to
64e9cff
Compare
|
In light of some recent developments, I would actually be in favour of perhaps merging this PR with the beta version of the prop-types lib. Manually resolving merge conflicts caused by version bumps is not fun. |
varl
approved these changes
Sep 21, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ToDo
Findings regarding the prop-types v1 -> v3 migration
This PR contains relevant changes but also served as a test case for the codemod I produced in dhis2/prop-types#254 and the migration process from v1 to v3 in general. Below are some findings:
package.jsonfile(s):prop-typeswill need to be added as a dependency if it wasn't there already. The only exception would be a theoretical scenario where only our custom prop-types functions are used and no regular prop-types from theprop-typeslib.@dhis2/prop-typesshould be removed completely if the project only uses regular prop-types from theprop-typespackage.@dhis2/prop-typespackage to v3 is another change to thepackage.jsonfile, but that can be ignored here because I am assuming dependabot PRs which already include this change.)package.jsonfiles to update.I am certain we need to document how to migrate from v1 to v3 (and probably also for v2), but I have a lot of questions about this still, which I will write in bold:
package.jsonfile(s), and make sense of the changes generated by the codemod.@dhis2/cli-utils-codemods. Please explain how this would actually work?package.jsonfile(s) after the codemod ran.