refactor: only export custom prop-type functions #254
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
BREAKING CHANGE: we no longer append to and re-export the `PropTypes` object from the `prop-types` package. Instead it will need to be installed by the consumer and regular prop-types need to be imported from there. Only the DHIS2 custom prop-types can be imported from this package from now on.
BREAKING CHANGE: regular prop-types can no longer be imported from @dhis2/prop-types BREAKING CHANGE: DHIS2 custom prop-types are only exported as named functions
HendrikThePendric
changed the title
|
Converted this PR to draft as I uncovered some prop-types that are not transformed correctly yet. Specifically function arguments, and arrays (often also used in function arguments) are not supported yet, but they need to be. |
This includes regular arguments and array arguments too
HendrikThePendric
deleted the
CLI-218-only-export-own-prop-types-functions
branch
dhis2-bot
added a commit
that referenced
this pull request
Sep 19, 2021
# [3.0.0-beta.1](v2.0.4...v3.0.0-beta.1) (2021-09-19) ### Code Refactoring * only export custom prop-type functions ([#254](#254)) ([c2262e0](c2262e0)) ### BREAKING CHANGES * prop-types from the `props-types` package are no longer re-exported from `@dhis2/prop-types` * `@dhis2/prop-types` no longer exports a default, the DHIS2 custom prop-types are only available as named imports
|
🎉 This PR is included in version 3.0.0-beta.1 🎉 The release is available on: Your semantic-release bot 📦🚀 |
1 task
dhis2-bot
added a commit
that referenced
this pull request
Sep 30, 2021
# [3.0.0](v2.0.4...v3.0.0) (2021-09-30) ### Bug Fixes * publish codemod and add migration docs ([#260](#260)) ([7a0fc61](7a0fc61)) ### Code Refactoring * only export custom prop-type functions ([#254](#254)) ([c2262e0](c2262e0)) ### BREAKING CHANGES * prop-types from the `props-types` package are no longer re-exported from `@dhis2/prop-types` * `@dhis2/prop-types` no longer exports a default, the DHIS2 custom prop-types are only available as named imports
|
🎉 This PR is included in version 3.0.0 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.