fix: prevent access-before-initialisation storybook errors #414
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
HendrikThePendric
changed the title
|
Test summary
Run details
View run in Cypress Dashboard ➡️ This comment has been generated by cypress-bot as a result of this project's GitHub integration settings. You can manage this integration in this project's settings in the Cypress Dashboard |
|
Ok, so we've narrowed it down to either the imports in ShareBlock.js or SharingList.js. I've removed the code in those components, and just left a dummy component and all the imports. I've been going through the imports and enabling them one by one, and then rerunning the cypress tests to verify. It seems to be the imports because if you enable them all, the e2e tests fail, and if you disable them all, the e2e tests pass. So far, the imports enabled in this PR: #416 are all ok when testing locally. So it's one of the commented imports that's causing the problems. Will continue tomorrow. |
ismay
approved these changes
Dec 16, 2020
HendrikThePendric
deleted the
fix-storybook-cannot-acces-before-initialization-error
branch
ismay
pushed a commit
that referenced
this pull request
Dec 16, 2020
* fix: stop importing from index files * chore(yarn): update yarn.lock * fix(sharing-dialog): stop importing from @dhis2/ui Co-authored-by: ismay <[email protected]>
edoardo
pushed a commit
that referenced
this pull request
Jan 13, 2021
* fix: stop importing from index files * chore(yarn): update yarn.lock * fix(sharing-dialog): stop importing from @dhis2/ui Co-authored-by: ismay <[email protected]>
edoardo
pushed a commit
that referenced
this pull request
Apr 7, 2021
* fix: stop importing from index files * chore(yarn): update yarn.lock * fix(sharing-dialog): stop importing from @dhis2/ui Co-authored-by: ismay <[email protected]>
edoardo
pushed a commit
that referenced
this pull request
Jul 12, 2021
* fix: stop importing from index files * chore(yarn): update yarn.lock * fix(sharing-dialog): stop importing from @dhis2/ui Co-authored-by: ismay <[email protected]>
edoardo
pushed a commit
that referenced
this pull request
Jul 16, 2021
* fix: stop importing from index files * chore(yarn): update yarn.lock * fix(sharing-dialog): stop importing from @dhis2/ui Co-authored-by: ismay <[email protected]>
edoardo
pushed a commit
that referenced
this pull request
Aug 18, 2021
* fix: stop importing from index files * chore(yarn): update yarn.lock * fix(sharing-dialog): stop importing from @dhis2/ui Co-authored-by: ismay <[email protected]>
dhis2-bot
added a commit
that referenced
this pull request
Aug 24, 2021
# [6.18.0-alpha.1](v6.17.0...v6.18.0-alpha.1) (2021-08-24) ### Bug Fixes * add remove for user/groups ([c2149d9](c2149d9)) * add stories for dashboard cascading sharing ([e4251fe](e4251fe)) * fix crash when an access string contains data settings ([f9ca3e5](f9ca3e5)) * fix i18n string interpolation ([752b641](752b641)) * fix i18n.t usage ([bf02805](bf02805)) * fix icons while waiting for ui-icons to be released ([bcf4c22](bcf4c22)) * fix import ([da9f35e](da9f35e)) * fix imports ([725b6f9](725b6f9)) * fix imports after merging alpha ([91f6737](91f6737)) * fix prop types ([374ca57](374ca57)) * fix prop types ([a00b1ea](a00b1ea)) * fix wrong boolean default for view and edit access ([919a287](919a287)) * implement disabled access select (external/public) ([4938603](4938603)) * implement latest design ([f3f5040](f3f5040)) * make clear the type of access as per latest design ([1b0ada7](1b0ada7)) * minor text correction ([9d91931](9d91931)) * pass label for the search input ([2d8ceb8](2d8ceb8)) * prevent access-before-initialisation storybook errors ([#414](#414)) ([da68680](da68680)) * use fixed version for [@dhis2-ui](https://github.com/dhis2-ui) dependencies ([6d89ba4](6d89ba4)) * use the callback format for error handling ([15550cc](15550cc)) ### Features * Add DHIS2 Sharing Dialog ([758bb10](758bb10)) * implement cascade sharing for dashboard TECH-274 ([b1f7fcd](b1f7fcd)) * implement cascading sharing for dashboards ([efff245](efff245)) * search as you type for user/groups ([5fd447c](5fd447c))
dhis2-bot
added a commit
that referenced
this pull request
Aug 24, 2021
# [6.19.0-alpha.1](v6.18.0...v6.19.0-alpha.1) (2021-08-24) ### Bug Fixes * **release:** trigger release ([adbca7e](adbca7e)) * add remove for user/groups ([c2149d9](c2149d9)) * add stories for dashboard cascading sharing ([e4251fe](e4251fe)) * fix crash when an access string contains data settings ([f9ca3e5](f9ca3e5)) * fix i18n string interpolation ([752b641](752b641)) * fix i18n.t usage ([bf02805](bf02805)) * fix icons while waiting for ui-icons to be released ([bcf4c22](bcf4c22)) * fix import ([da9f35e](da9f35e)) * fix imports ([725b6f9](725b6f9)) * fix imports after merging alpha ([91f6737](91f6737)) * fix prop types ([374ca57](374ca57)) * fix prop types ([a00b1ea](a00b1ea)) * fix wrong boolean default for view and edit access ([919a287](919a287)) * implement disabled access select (external/public) ([4938603](4938603)) * implement latest design ([f3f5040](f3f5040)) * make clear the type of access as per latest design ([1b0ada7](1b0ada7)) * minor text correction ([9d91931](9d91931)) * pass label for the search input ([2d8ceb8](2d8ceb8)) * prevent access-before-initialisation storybook errors ([#414](#414)) ([da68680](da68680)) * use fixed version for [@dhis2-ui](https://github.com/dhis2-ui) dependencies ([6d89ba4](6d89ba4)) * use the callback format for error handling ([15550cc](15550cc)) ### Features * Add DHIS2 Sharing Dialog ([758bb10](758bb10)) * implement cascade sharing for dashboard TECH-274 ([b1f7fcd](b1f7fcd)) * implement cascading sharing for dashboards ([efff245](efff245)) * search as you type for user/groups ([5fd447c](5fd447c))
dhis2-bot
added a commit
that referenced
this pull request
Aug 31, 2021
# [6.20.0-alpha.1](v6.19.1...v6.20.0-alpha.1) (2021-08-31) ### Bug Fixes * **release:** trigger release ([adbca7e](adbca7e)) * add remove for user/groups ([c2149d9](c2149d9)) * add stories for dashboard cascading sharing ([e4251fe](e4251fe)) * fix crash when an access string contains data settings ([f9ca3e5](f9ca3e5)) * fix i18n string interpolation ([752b641](752b641)) * fix i18n.t usage ([bf02805](bf02805)) * fix icons while waiting for ui-icons to be released ([bcf4c22](bcf4c22)) * fix import ([da9f35e](da9f35e)) * fix imports ([725b6f9](725b6f9)) * fix imports after merging alpha ([91f6737](91f6737)) * fix prop types ([374ca57](374ca57)) * fix prop types ([a00b1ea](a00b1ea)) * fix wrong boolean default for view and edit access ([919a287](919a287)) * implement disabled access select (external/public) ([4938603](4938603)) * implement latest design ([f3f5040](f3f5040)) * make clear the type of access as per latest design ([1b0ada7](1b0ada7)) * minor text correction ([9d91931](9d91931)) * pass label for the search input ([2d8ceb8](2d8ceb8)) * prevent access-before-initialisation storybook errors ([#414](#414)) ([da68680](da68680)) * use fixed version for [@dhis2-ui](https://github.com/dhis2-ui) dependencies ([6d89ba4](6d89ba4)) * use the callback format for error handling ([15550cc](15550cc)) ### Features * Add DHIS2 Sharing Dialog ([758bb10](758bb10)) * implement cascade sharing for dashboard TECH-274 ([b1f7fcd](b1f7fcd)) * implement cascading sharing for dashboards ([efff245](efff245)) * search as you type for user/groups ([5fd447c](5fd447c))
dhis2-bot
added a commit
that referenced
this pull request
Aug 31, 2021
# [6.20.0](v6.19.1...v6.20.0) (2021-08-31) ### Bug Fixes * fix info and explanation strings and use pluralisation ([295836a](295836a)) * **release:** trigger release ([adbca7e](adbca7e)) * add remove for user/groups ([c2149d9](c2149d9)) * add stories for dashboard cascading sharing ([e4251fe](e4251fe)) * fix crash when an access string contains data settings ([f9ca3e5](f9ca3e5)) * fix i18n string interpolation ([752b641](752b641)) * fix i18n.t usage ([bf02805](bf02805)) * fix icons while waiting for ui-icons to be released ([bcf4c22](bcf4c22)) * fix import ([da9f35e](da9f35e)) * fix imports ([725b6f9](725b6f9)) * fix imports after merging alpha ([91f6737](91f6737)) * fix prop types ([374ca57](374ca57)) * fix prop types ([a00b1ea](a00b1ea)) * fix wrong boolean default for view and edit access ([919a287](919a287)) * implement disabled access select (external/public) ([4938603](4938603)) * implement latest design ([f3f5040](f3f5040)) * make clear the type of access as per latest design ([1b0ada7](1b0ada7)) * minor text correction ([9d91931](9d91931)) * pass label for the search input ([2d8ceb8](2d8ceb8)) * prevent access-before-initialisation storybook errors ([#414](#414)) ([da68680](da68680)) * use fixed version for [@dhis2-ui](https://github.com/dhis2-ui) dependencies ([6d89ba4](6d89ba4)) * use the callback format for error handling ([15550cc](15550cc)) ### Features * **ui:** expose SharingDialog from @dhis2/ui ([d842c23](d842c23)) * Add DHIS2 Sharing Dialog ([758bb10](758bb10)) * implement cascade sharing for dashboard TECH-274 ([b1f7fcd](b1f7fcd)) * implement cascading sharing for dashboards ([efff245](efff245)) * offline mode, form interaction is disabled ([0bc3d3b](0bc3d3b)) * search as you type for user/groups ([5fd447c](5fd447c))
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://jira.dhis2.org/browse/LIBS-89