fix: fix prop types

dhis2 · Aug 18, 2021 · a00b1ea · a00b1ea
1 parent 4f81b75
commit a00b1ea
Show file tree

Hide file tree

Showing 6 changed files with 25 additions and 21 deletions.
diff --git a/components/sharing-dialog/src/access-select.js b/components/sharing-dialog/src/access-select.js
@@ -47,14 +47,14 @@ export const AccessSelect = ({
 )
 
 AccessSelect.propTypes = {
-    access: PropTypes.string,
-    accessOptions: PropTypes.array,
+    access: PropTypes.string.isRequired,
+    accessOptions: PropTypes.array.isRequired,
+    onChange: PropTypes.func.isRequired,
     disabled: PropTypes.bool,
     label: PropTypes.string,
     placeholder: PropTypes.string,
     prefix: PropTypes.string,
     showRemoveOption: PropTypes.bool,
-    onChange: PropTypes.func,
 }
 
 const CustomSingleSelectOption = ({
@@ -78,9 +78,9 @@ const CustomSingleSelectOption = ({
 )
 
 CustomSingleSelectOption.propTypes = {
+    label: PropTypes.string.isRequired,
+    value: PropTypes.string.isRequired,
+    onClick: PropTypes.func.isRequired,
     active: PropTypes.bool,
     destructive: PropTypes.bool,
-    label: PropTypes.string,
-    value: PropTypes.string,
-    onClick: PropTypes.func,
 }
diff --git a/components/sharing-dialog/src/autocomplete/autocomplete.js b/components/sharing-dialog/src/autocomplete/autocomplete.js
@@ -28,8 +28,8 @@ const SearchResults = ({ searchResults, onClick }) => (
 )
 
 SearchResults.propTypes = {
-    searchResults: PropTypes.array,
-    onClick: PropTypes.func,
+    searchResults: PropTypes.array.isRequired,
+    onClick: PropTypes.func.isRequired,
 }
 
 export const Autocomplete = ({
@@ -55,7 +55,6 @@ export const Autocomplete = ({
         }
     }, [])
 
-    // TODO debounce
     const onInputChange = ({ value }) => {
         onSearch(value)
     }
@@ -98,12 +97,12 @@ Autocomplete.defaultProps = {
 }
 
 Autocomplete.propTypes = {
+    searchResults: PropTypes.array.isRequired,
     dataTest: PropTypes.string,
     inputWidth: PropTypes.string,
     label: PropTypes.string,
     maxHeight: PropTypes.string,
     placeholder: PropTypes.string,
-    searchResults: PropTypes.array,
     value: PropTypes.string,
     onChange: PropTypes.func,
     onClose: PropTypes.func,

diff --git a/components/sharing-dialog/src/icons/avatar.js b/components/sharing-dialog/src/icons/avatar.js
@@ -2,7 +2,7 @@ import PropTypes from '@dhis2/prop-types'
 import React from 'react'
 import { avatarStyles } from '../sharing-dialog.styles'
 
-export const Avatar = ({ name } = { name: 'USER' }) => {
+export const Avatar = ({ name }) => {
     const nameParts = name.split(' ')
 
     let initials = nameParts.shift().charAt(0)
@@ -19,6 +19,10 @@ export const Avatar = ({ name } = { name: 'USER' }) => {
     )
 }
 
+Avatar.defaultProps = {
+    name: 'USER',
+}
+
 Avatar.propTypes = {
-    name: PropTypes.string,
+    name: PropTypes.string.isRequired,
 }
diff --git a/components/sharing-dialog/src/share-block.js b/components/sharing-dialog/src/share-block.js
@@ -134,5 +134,5 @@ export const ShareBlock = ({ onAdd }) => {
 }
 
 ShareBlock.propTypes = {
-    onAdd: PropTypes.func,
+    onAdd: PropTypes.func.isRequired,
 }
diff --git a/components/sharing-dialog/src/sharing-dialog.js b/components/sharing-dialog/src/sharing-dialog.js
@@ -35,7 +35,7 @@ const mutation = {
 }
 
 export const SharingDialog = ({
-    initialSharingSettings = defaultSharingSettings,
+    initialSharingSettings,
     id,
     type,
     onClose,
@@ -268,11 +268,14 @@ export const SharingDialog = ({
 }
 
 SharingDialog.defaultProps = {
+    initialSharingSettings: defaultSharingSettings,
     onError: Function.prototype,
     onSave: Function.prototype,
 }
 
 SharingDialog.propTypes = {
+    type: PropTypes.string.isRequired,
+    onClose: PropTypes.func.isRequired,
     id: PropTypes.string,
     initialSharingSettings: PropTypes.shape({
         allowExternal: PropTypes.bool,
@@ -283,8 +286,6 @@ SharingDialog.propTypes = {
         public: PropTypes.string,
         users: PropTypes.object,
     }),
-    type: PropTypes.string,
-    onClose: PropTypes.func,
     onError: PropTypes.func,
     onSave: PropTypes.func,
 }
diff --git a/components/sharing-dialog/src/sharing-list-item.js b/components/sharing-dialog/src/sharing-list-item.js
@@ -69,11 +69,11 @@ export const SharingListItem = ({
 }
 
 SharingListItem.propTypes = {
-    access: PropTypes.string,
-    accessOptions: PropTypes.array,
+    access: PropTypes.string.isRequired,
+    accessOptions: PropTypes.array.isRequired,
+    name: PropTypes.string.isRequired,
+    target: PropTypes.string.isRequired,
+    onChange: PropTypes.func.isRequired,
     disabled: PropTypes.bool,
-    name: PropTypes.string,
-    target: PropTypes.string,
-    onChange: PropTypes.func,
     onRemove: PropTypes.func,
 }