feat: enable legend tab for column and bar (DHIS2-147) #1355
Conversation
| VIS_TYPE_SINGLE_VALUE, | ||
| isStacked as getIsStacked, |
There was a problem hiding this comment.
Why the rename?
Perhaps it should be called isStackedType for consistency with the others?
There was a problem hiding this comment.
Because I wanted to pass isStacked to defaultProps without renaming the prop and obviously I can't have const isStacked = isStacked(type) 🙂 alternatively I could keep the original name of the Analytics prop and use a different name for my const, but I thought isStacked: someOtherName would be less clean the current way.
There was a problem hiding this comment.
The exported prop from Analytics could be renamed on the Analytics side but that would cause a breaking change that I don't think is worth it.
There was a problem hiding this comment.
Yes, I thought about the breaking change.
Let's keep it as it is, or use isStacked as isStackedType 😆
# [35.13.0](v35.12.34...v35.13.0) (2020-10-21) ### Features * enable legend tab for column and bar (DHIS2-147) ([#1355](#1355)) ([04bb5a6](04bb5a6))
|
🎉 This PR is included in version 35.13.0 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Implements DHIS2-147
Requires dhis2/analytics#650 and dhis2/analytics#656
Key features
Legendtab forColumnandBarconfigto use props from Analytics instead of hardcoding themLegendSetnames from the APIDescription
Started out as a tiny change to enable the
Legendtab forColumnandBar, the rest of the legend implementation can be found in the Analytics PR.To prevent the
configfrom mismatching with the Highcharts output, I refactored theconfigto use centralised props from Analytics instead of using hardcoded values. Meaning that the config will need minimal maintenance to work with future vis types.LegendSetnames are now fetched from the API, which are passed to Analytics to be used in the hover tooltip in Highcharts.Screenshots
Legend tab enabled for Column
Legend tab enabled for Bar
