fix: display info msg when no legend is found (DHIS2-147) #656
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
martinkrulltott
changed the title
dhis2-bot
added a commit
that referenced
this pull request
Oct 21, 2020
## [11.1.1](v11.1.0...v11.1.1) (2020-10-21) ### Bug Fixes * display info msg when no legend is found (DHIS2-147) ([#656](#656)) ([19d7860](19d7860))
|
🎉 This PR is included in version 11.1.1 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Implements DHIS2-147
Relates to dhis2/data-visualizer-app#1355
Key features
Description
When the legend option “Use pre-defined legend per data item” is used, each series item is assigned their own legend. In case the series item has no legend assigned to it, the hover tooltip will no display a correct info message to inform the user why no legend is applied.
Screenshots
previously it was incorrectly showing a an empty row with just a
:character when no legend was foundno legend now shows a proper info message
items with legend still show their regular tooltip as before
