Fix tests to pass with -f-with-http
#2382
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… partly by mocking some imports better and partly by disabling some tests that are not worth the effort to mock. Fixes #2380
|
This works on my end. However, I have a couple additional changes that I would like to propose: #2383 Also, this particular doctest is trying to make network calls: dhall-haskell/dhall/src/Dhall/Tutorial.hs Lines 378 to 379 in ecef9b7 I don't know of a way to easily disable a doctest without changing the way it renders in Haddock, so I asked. |
Allows for disabling network-dependent tests independently of the `with-http` flag.
hololeap
reviewed
Mar 22, 2022
| @@ -375,13 +376,23 @@ import Dhall | |||
| -- | |||
| -- ... and you can reference that expression either directly: | |||
| -- | |||
| #if defined(WITH_HTTP) && defined(USE_HTTP_CLIENT_TLS) && defined(NETWORK_TESTS) | |||
There was a problem hiding this comment.
Just FYI, I'm not sure defined(USE_HTTP_CLIENT_TLS) is necessary here... 🤔
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
… partly by mocking some imports better and partly by
disabling some tests that are not worth the effort to mock.
Fixes #2380