Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Tests fail to compile when with-http flag is disabled #2380

Closed
hololeap opened this issue Feb 9, 2022 · 1 comment · Fixed by #2382
Closed

Tests fail to compile when with-http flag is disabled #2380

hololeap opened this issue Feb 9, 2022 · 1 comment · Fixed by #2382
Labels
build Building, testing, installing, packaging, etc

Comments

@hololeap
Copy link

hololeap commented Feb 9, 2022

I'm packaging dhall for Gentoo, and it's important for us to include the option for testing if the upstream package includes it. However, our testing (and the build in general) is run in a sandbox with no network access.

Thankfully, there seems to have been an effort to allow for offline testing with the WITH_HTTP cpp symbol functioning as a switch to allow this. 👍

However, it does not seem as though this functionality is currently being tested, and on current master the tests fail to even compile when the with-http flag is disabled.
@sjakobi sjakobi added the build Building, testing, installing, packaging, etc label Feb 10, 2022
Gabriella439 added a commit that referenced this issue Feb 13, 2022
@Gabriella439
Fix tests to pass with -f-with-http
baffd2a 
… partly by mocking some imports better and partly by
disabling some tests that are not worth the effort to mock.

Fixes #2380
@Gabriella439 Gabriella439 mentioned this issue Feb 13, 2022
Merged
@Gabriella439
Copy link
Collaborator

Fix is up here: #2382

Gabriella439 added a commit that referenced this issue Apr 8, 2022
@Gabriella439
Fix tests to pass with -f-with-http (#2382)
c1c2a34 
… partly by mocking some imports better and partly by
disabling some tests that are not worth the effort to mock.

Fixes #2380
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
build Building, testing, installing, packaging, etc
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fix tests to pass with -f-with-http dhall-lang/dhall-haskell
3 participants
@Gabriella439 @sjakobi @hololeap