Skip to content

fix: remove polluting google log library#292

Closed
aeneasr wants to merge 1 commit intodgraph-io:masterfrom
ory:fix-glog
Closed

fix: remove polluting google log library#292
aeneasr wants to merge 1 commit intodgraph-io:masterfrom
ory:fix-glog

Conversation

@aeneasr
Copy link

@aeneasr aeneasr commented Jan 20, 2022

For more context please see discussion https://discuss.dgraph.io/t/ristretto-0-1-0-pollutes-the-flags-namespace/14561

By reverting #263 not only is the number of dependencies this library has greatly reduced, but projects using this library will not unavoidably panic.


This change is Reviewable

For more context please see discussion https://discuss.dgraph.io/t/ristretto-0-1-0-pollutes-the-flags-namespace/14561

By reverting dgraph-io#263 not only is the number of dependencies this library has greatly reduced, but projects using this library will not unavoidably panic.
@aeneasr aeneasr requested a review from manishrjain as a code owner January 20, 2022 21:20
@CLAassistant
Copy link

CLAassistant commented Jan 20, 2022

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.
You have signed the CLA already but the status is still pending? Let us recheck it.

@@ -1,3 +1,4 @@
//go:build jemalloc && allocator
Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done by Go 1.17 gofmt

@floatdrop
Copy link

@manishrjain hey, can this be merged? glog pollutes our binary flags. Thanks!

@manishrjain
Copy link
Contributor

Hey @floatdrop ,

I'm no longer associated with Dgraph Labs. I'm not maintaining repositories owned by dgraph-io. I've forks of these repos in outcaste-io. If you want to switch to that and send me the PR, I'll be happy to review it.

https://github.com/outcaste-io/ristretto

@aeneasr
Copy link
Author

aeneasr commented Mar 23, 2022

Is anyone maintaing this repo or is it essentially abandoned?

@karlmcguire
Copy link
Contributor

@mangalaman93
Copy link
Contributor

A similar PR is merged now #350

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Development

Successfully merging this pull request may close these issues.

6 participants