fix: remove polluting google log library#292
fix: remove polluting google log library#292aeneasr wants to merge 1 commit intodgraph-io:masterfrom
Conversation
For more context please see discussion https://discuss.dgraph.io/t/ristretto-0-1-0-pollutes-the-flags-namespace/14561 By reverting dgraph-io#263 not only is the number of dependencies this library has greatly reduced, but projects using this library will not unavoidably panic.
|
|
| @@ -1,3 +1,4 @@ | |||
| //go:build jemalloc && allocator | |||
|
@manishrjain hey, can this be merged? glog pollutes our binary flags. Thanks! |
|
Hey @floatdrop , I'm no longer associated with Dgraph Labs. I'm not maintaining repositories owned by dgraph-io. I've forks of these repos in outcaste-io. If you want to switch to that and send me the PR, I'll be happy to review it. https://github.com/outcaste-io/ristretto |
|
Is anyone maintaing this repo or is it essentially abandoned? |
|
@aeneasr Abandoned, check out https://github.com/outcaste-io/ristretto |
|
A similar PR is merged now #350 |
For more context please see discussion https://discuss.dgraph.io/t/ristretto-0-1-0-pollutes-the-flags-namespace/14561
By reverting #263 not only is the number of dependencies this library has greatly reduced, but projects using this library will not unavoidably panic.
This change is