[BUG] The use of datadog-agent/pkg/obfuscate
pollutes the global flags defined by the program
#14984
Labels
datadog-agent/pkg/obfuscate
pollutes the global flags defined by the program
#14984
Any go binary that compiles and includes the current version of
datadog-agent/pkg/obfuscate
will pull in https://github.com/dgraph-io/ristretto v0.1 which then pulls https://github.com/golang/glog which by default defines global flags and starts some work duringinit()
https://github.com/golang/glog/blob/9ef845f417d839250ceabbc25c1b26101e772dd7/glog.go#L398-L412
https://github.com/dgraph-io/ristretto is currently abandoned (hypermodeinc/ristretto#292) and the fix to remove
glog
is included in the latest revision of the fork maintained by the original authors at https://github.com/outcaste-io/ristrettoWe hit this problem by including gopkg.in/DataDog/dd-trace-go.v1/ddtrace/tracer (which in turn depends on pkg/obfuscate) in our command line scripts.
Could you please swap the use of the abandoned https://github.com/dgraph-io/ristretto with the maintained fork?
The text was updated successfully, but these errors were encountered: