Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BUG] The use of datadog-agent/pkg/obfuscate pollutes the global flags defined by the program #14984

Closed
nik-andreev opened this issue Jan 6, 2023 · 0 comments · Fixed by #15005
Assignees

Comments

@nik-andreev
Copy link

nik-andreev commented Jan 6, 2023

Any go binary that compiles and includes the current version of datadog-agent/pkg/obfuscate will pull in https://github.com/dgraph-io/ristretto v0.1 which then pulls https://github.com/golang/glog which by default defines global flags and starts some work during init()

https://github.com/golang/glog/blob/9ef845f417d839250ceabbc25c1b26101e772dd7/glog.go#L398-L412

https://github.com/dgraph-io/ristretto is currently abandoned (hypermodeinc/ristretto#292) and the fix to remove glog is included in the latest revision of the fork maintained by the original authors at https://github.com/outcaste-io/ristretto

We hit this problem by including gopkg.in/DataDog/dd-trace-go.v1/ddtrace/tracer (which in turn depends on pkg/obfuscate) in our command line scripts.

Could you please swap the use of the abandoned https://github.com/dgraph-io/ristretto with the maintained fork?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants