chore: Bump ic-ref to track legacy3 branch#583
Merged
Conversation
in #471 we added running the e2e tests aginst the `legacy2` branch of `ic-ref`, which was tailured to SDK’s behaviour at that time. That PR was green. But it was merged without updating the branch, and in the meantime SKD’s `master` updated `replica` to 0.5.4, and also changed `dfx` accordingly. At that version, `dfx` could no longer talk to `ic-ref`, and the test made `master` red. So I creaed a new branch `legacy3`, off `release-0.2` in `ic-ref`, making the necessary adjustments to be compatible with `dfx` again. These were: * Do not require CBOR tag * Make `sender` field optional * Do not check signatures * Do not require canister registration before installation
basvandijk
approved these changes
Apr 21, 2020
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
in #471 we added running the e2e tests aginst the
legacy2branch ofic-ref, which was tailured to SDK’s behaviour at that time. That PRwas green.
But it was merged without updating the branch, and in the meantime SKD’s
masterupdatedreplicato 0.5.4, and also changeddfxaccordingly.At that version,
dfxcould no longer talk toic-ref, and the testmade
masterred.So I creaed a new branch
legacy3, offrelease-0.2inic-ref,making the necessary adjustments to be compatible with
dfxagain.These were:
senderfield optional