Skip to content

bump motoko#351

Merged
chenyan-dfinity merged 1 commit intomasterfrom
bump-motoko
Jan 31, 2020
Merged

bump motoko#351
chenyan-dfinity merged 1 commit intomasterfrom
bump-motoko

Conversation

@chenyan-dfinity
Copy link
Contributor

@chenyan-dfinity chenyan-dfinity commented Jan 31, 2020

No description provided.

@hansl
Copy link
Contributor

hansl commented Jan 31, 2020

Two questions;

  1. is this necessary for 0.5?
  2. if not but you still want to pull this in for 0.5, could you summarize the changes from the last SHA to this one?

@chenyan-dfinity
Copy link
Contributor Author

chenyan-dfinity commented Jan 31, 2020

  • The polymorphic type inside actor bug is fixed. It's nice to push this fix soon, as your live stream made it more public.
  • Much better syntax error!!

@chenyan-dfinity chenyan-dfinity merged commit 99dca97 into master Jan 31, 2020
@chenyan-dfinity chenyan-dfinity deleted the bump-motoko branch January 31, 2020 22:03
@nomeata
Copy link
Contributor

nomeata commented Feb 1, 2020

@chenyan-dfinity
I recommend pasting

cd motoko; git log --oneline --first-parent old-sha..new-sha

into the commit message (automation for that is suggested in nmattia/niv#69)

dfinity-bot added a commit that referenced this pull request Jan 22, 2021
@dfinity-bot
build: niv common: update 9c744b80 -> 670dfa15
a14a254 
## Changelog for common:
Branch: master
Commits: [dfinity-lab/common@9c744b80...670dfa15](https://github.com/dfinity-lab/common/compare/9c744b80d1750dc782d45315518a9a7445a417b3...670dfa15fc073b96d14918331505810b87e91597)

* [`ca3fd331`](https://github.com/dfinity-lab/common/commit/ca3fd331cb3a4eaffa7d7aa87ad9707a5c42d52a) Add SSH key for nasm's new laptop ([dfinity-lab/common⁠#351](http://r.duckduckgo.com/l/?uddg=https://github.com/dfinity-lab/common/issues/351))
* [`670dfa15`](https://github.com/dfinity-lab/common/commit/670dfa15fc073b96d14918331505810b87e91597) mk-jobset.nix: ([dfinity-lab/common⁠#350](http://r.duckduckgo.com/l/?uddg=https://github.com/dfinity-lab/common/issues/350))
mergify bot pushed a commit that referenced this pull request Jan 22, 2021
@dfinity-bot
build: niv common: update 9c744b80 -> 670dfa15 (#1322)
77f41e8 
## Changelog for common:
Branch: master
Commits: [dfinity-lab/common@9c744b80...670dfa15](https://github.com/dfinity-lab/common/compare/9c744b80d1750dc782d45315518a9a7445a417b3...670dfa15fc073b96d14918331505810b87e91597)

* [`ca3fd331`](https://github.com/dfinity-lab/common/commit/ca3fd331cb3a4eaffa7d7aa87ad9707a5c42d52a) Add SSH key for nasm's new laptop ([dfinity-lab/common⁠#351](http://r.duckduckgo.com/l/?uddg=https://github.com/dfinity-lab/common/issues/351))
* [`670dfa15`](https://github.com/dfinity-lab/common/commit/670dfa15fc073b96d14918331505810b87e91597) mk-jobset.nix: ([dfinity-lab/common⁠#350](http://r.duckduckgo.com/l/?uddg=https://github.com/dfinity-lab/common/issues/350))
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@hansl hansl hansl approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@chenyan-dfinity @hansl @nomeata