Closed
Conversation
Contributor
Author
|
(Putting this into non-draft status just to get CI to run.) |
Contributor
|
I think we need to design a DSL for configuration and build. The CLI command can then be extremely minimal without any flags. All configuration/build flags will be extracted from the DSL. I like Google's internal GCL language a lot, and there seems to be an open source version: https://jsonnet.org/articles/design.html, with a third-party Rust support: https://github.com/anguslees/rust-jsonnet. Unfortunately they made a compromise by targeting JSON as the output format, but the main features of the language are preserved. A DSL like this should be able to unify everything: the cache, build params, deployment configs all written in one language in a single configurable place. No more code changes in the dfx binary. |
Contributor
Author
|
Closing this experiment. Continued discussion about scripting dfx for testing purposes is here, cc @hansl @chenyan-dfinity |
dfinity-bot
added a commit
that referenced
this pull request
Aug 15, 2020
## Changelog for advisory-db: Branch: Commits: [rustsec/advisory-db@fdc3c78d...8fba4e52](rustsec/advisory-db@fdc3c78...8fba4e5) * [`f81972e8`](rustsec/advisory-db@f81972e) Informational advisory for rust-lang-nursery/failure[RustSec/advisory-db#336](http://r.duckduckgo.com/l/?uddg=https://github.com/RustSec/advisory-db/issues/336) * [`5cc05895`](rustsec/advisory-db@5cc0589) Add advisory for rgb * [`a61e5b2c`](rustsec/advisory-db@a61e5b2) Fix spelling * [`9611ff4c`](rustsec/advisory-db@9611ff4) Added note about invariants, specified resolution * [`90624f4e`](rustsec/advisory-db@90624f4) Assigned RUSTSEC-2020-0029 to rgb ([RustSec/advisory-db#350](http://r.duckduckgo.com/l/?uddg=https://github.com/RustSec/advisory-db/issues/350)) * [`7ba77515`](rustsec/advisory-db@7ba7751) Apply PR feedback * [`8cfebb1f`](rustsec/advisory-db@8cfebb1) Assigned RUSTSEC-2019-0036 to failure * [`8fba4e52`](rustsec/advisory-db@8fba4e5) fix disclosure date
mergify bot
pushed a commit
that referenced
this pull request
Aug 15, 2020
## Changelog for advisory-db: Branch: Commits: [rustsec/advisory-db@fdc3c78d...8fba4e52](rustsec/advisory-db@fdc3c78...8fba4e5) * [`f81972e8`](rustsec/advisory-db@f81972e) Informational advisory for rust-lang-nursery/failure[RustSec/advisory-db#336](http://r.duckduckgo.com/l/?uddg=https://github.com/RustSec/advisory-db/issues/336) * [`5cc05895`](rustsec/advisory-db@5cc0589) Add advisory for rgb * [`a61e5b2c`](rustsec/advisory-db@a61e5b2) Fix spelling * [`9611ff4c`](rustsec/advisory-db@9611ff4) Added note about invariants, specified resolution * [`90624f4e`](rustsec/advisory-db@90624f4) Assigned RUSTSEC-2020-0029 to rgb ([RustSec/advisory-db#350](http://r.duckduckgo.com/l/?uddg=https://github.com/RustSec/advisory-db/issues/350)) * [`7ba77515`](rustsec/advisory-db@7ba7751) Apply PR feedback * [`8cfebb1f`](rustsec/advisory-db@8cfebb1) Assigned RUSTSEC-2019-0036 to failure * [`8fba4e52`](rustsec/advisory-db@8fba4e5) fix disclosure date
dfinity-bot
added a commit
that referenced
this pull request
Jan 22, 2021
## Changelog for common: Branch: master Commits: [dfinity-lab/common@9c744b80...670dfa15](https://github.com/dfinity-lab/common/compare/9c744b80d1750dc782d45315518a9a7445a417b3...670dfa15fc073b96d14918331505810b87e91597) * [`ca3fd331`](https://github.com/dfinity-lab/common/commit/ca3fd331cb3a4eaffa7d7aa87ad9707a5c42d52a) Add SSH key for nasm's new laptop ([dfinity-lab/common#351](http://r.duckduckgo.com/l/?uddg=https://github.com/dfinity-lab/common/issues/351)) * [`670dfa15`](https://github.com/dfinity-lab/common/commit/670dfa15fc073b96d14918331505810b87e91597) mk-jobset.nix: ([dfinity-lab/common#350](http://r.duckduckgo.com/l/?uddg=https://github.com/dfinity-lab/common/issues/350))
mergify bot
pushed a commit
that referenced
this pull request
Jan 22, 2021
## Changelog for common: Branch: master Commits: [dfinity-lab/common@9c744b80...670dfa15](https://github.com/dfinity-lab/common/compare/9c744b80d1750dc782d45315518a9a7445a417b3...670dfa15fc073b96d14918331505810b87e91597) * [`ca3fd331`](https://github.com/dfinity-lab/common/commit/ca3fd331cb3a4eaffa7d7aa87ad9707a5c42d52a) Add SSH key for nasm's new laptop ([dfinity-lab/common#351](http://r.duckduckgo.com/l/?uddg=https://github.com/dfinity-lab/common/issues/351)) * [`670dfa15`](https://github.com/dfinity-lab/common/commit/670dfa15fc073b96d14918331505810b87e91597) mk-jobset.nix: ([dfinity-lab/common#350](http://r.duckduckgo.com/l/?uddg=https://github.com/dfinity-lab/common/issues/350))
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Not meant for
master.This branch gives a simpler, more predictable, more understandable behavior to
dfxand its commands. It's an ongoing experiment in software minimalism.