Skip to content

Comments

chore: fix update-docs workflow for forked PRs#2494

Merged
mergify[bot] merged 2 commits intomasterfrom
severin-fix-docs-workflow
Aug 25, 2022
Merged

chore: fix update-docs workflow for forked PRs#2494
mergify[bot] merged 2 commits intomasterfrom
severin-fix-docs-workflow

Conversation

@viviveevee
Copy link
Contributor

@viviveevee viviveevee commented Aug 25, 2022

Description

My update-docs.yml workflow breaks on PRs from forks (see #2490). Trying to fix this.

How Has This Been Tested?

According to this, the fix should work.

Checklist:

  • The title of this PR complies with Conventional Commits.
  • I have edited the CHANGELOG accordingly.
  • I have made corresponding changes to the documentation.

@viviveevee viviveevee requested a review from a team as a code owner August 25, 2022 06:38
Copy link
Contributor

@smallstepman smallstepman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! ✨

@mergify mergify bot merged commit 8b61cfb into master Aug 25, 2022
@mergify mergify bot deleted the severin-fix-docs-workflow branch August 25, 2022 12:06
@smallstepman
Copy link
Contributor

shall we try this out? :)

@viviveevee
Copy link
Contributor Author

It's trying in #2490 as we speak :)

@smallstepman
Copy link
Contributor

smallstepman commented Aug 25, 2022

@sesi200 looks like it's working now :)

fyi, in #2490 PR there was a new button in GHA/workflows section at the bottom of conversation tab, and it was something along these lines:

First-time contributors cannot run workflow before approval. 
+--------------------+
|   Approve and run  |
+--------------------+

shame I didn't think about taking a screenshot, but it looked 👌

@viviveevee
Copy link
Contributor Author

@smallstepman that had nothing to do with my changes, that's just something that appears on forks since they may contain malicious code

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants