Skip to content

Comments

docs: Correct a typo in docs/cli-reference/dfx-identity.md#2490

Merged
mergify[bot] merged 13 commits intodfinity:masterfrom
Benjamin-Loison:patch-1
Aug 31, 2022
Merged

docs: Correct a typo in docs/cli-reference/dfx-identity.md#2490
mergify[bot] merged 13 commits intodfinity:masterfrom
Benjamin-Loison:patch-1

Conversation

@Benjamin-Loison
Copy link
Contributor

@Benjamin-Loison Benjamin-Loison commented Aug 24, 2022

Description

Correct two occurrences of a typo in docs/cli-reference/dfx-identity.md which is also visible in https://internetcomputer.org/docs/current/references/cli-reference/dfx-identity/#options and when running dfx identity import -h.

Checklist:

  • The title of this PR complies with Conventional Commits.
  • I have edited the CHANGELOG accordingly. (not relevant)
  • I have made corresponding changes to the documentation.

@Benjamin-Loison Benjamin-Loison requested a review from a team as a code owner August 24, 2022 15:04
@ghost
Copy link

ghost commented Aug 24, 2022

Dear @Benjamin-Loison,

In order to potentially merge your code in this open-source repository and therefore proceed with your contribution, we need to have your approval on DFINITY's CLA1.

If you decide to agree with it, please visit this issue and read the instructions there.

— The DFINITY Foundation

Footnotes

  1. Contributor License Agreement

@ghost
Copy link

ghost commented Aug 24, 2022

Dear @Benjamin-Loison,

In order to potentially merge your code in this open-source repository and therefore proceed with your contribution, we need to have your approval on DFINITY's CLA1.

If you decide to agree with it, please visit this issue and read the instructions there.

— The DFINITY Foundation

Footnotes

  1. Contributor License Agreement

@viviveevee
Copy link
Contributor

Looks like the update-docs.yml I added recently breaks on forks... let me try to fix that

mergify bot pushed a commit that referenced this pull request Aug 25, 2022
# Description

My `update-docs.yml` workflow breaks on PRs from forks (see #2490). Trying to fix this.

# How Has This Been Tested?

According to [this](https://github.com/orgs/community/discussions/26409#discussioncomment-3251818), the fix should work.

# Checklist:

- [x] The title of this PR complies with [Conventional Commits](https://www.conventionalcommits.org/en/v1.0.0/).
- [ ] I have edited the CHANGELOG accordingly.
- [ ] I have made corresponding changes to the documentation.
@mergify mergify bot merged commit 909b787 into dfinity:master Aug 31, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants