feat: Add additional logging from bitcoin canister in replica.#2318
Merged
mergify[bot] merged 3 commits intomasterfrom Jul 12, 2022
Merged
feat: Add additional logging from bitcoin canister in replica.#2318mergify[bot] merged 3 commits intomasterfrom
mergify[bot] merged 3 commits intomasterfrom
Conversation
Configures the replica to emit additional logging from the bitcoin canister whenever the bitcoin feature is enabled. This helps show useful information to developers, such as the bitcoin height that the replica currently sees. Closes EXC-1131
Contributor
|
Does this play nicely with #2310? |
Contributor
Author
Contributor
Author
|
Note that this cannot be merged in master yet until we upgrade the replica version being used to something that includes this commit: dfinity/ic@901226d |
ghost
approved these changes
Jul 12, 2022
ghost
mentioned this pull request
mergify bot
pushed a commit
that referenced
this pull request
Jul 13, 2022
…replica." (#2342) Reverts #2318 This change is preventing us from updating to the latest hotfix replica (example: #2341 and [build failure](https://github.com/dfinity/sdk/runs/7326295725?check_suite_focus=true#step:8:1357)). Will re-incorporate this change when future replica releases support it.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Configures the replica to emit additional logging from the bitcoin
canister whenever the bitcoin feature is enabled. This helps show
useful information to developers, such as the bitcoin height that
the replica currently sees.
Fixes # EXC-1131
How Has This Been Tested?
Ran it locally with a bitcoin enabled project and verified that I'm seeing
the logs from the bitcoin canister that I'm expecting to see.
Checklist: