feat: Allow users to configure logging level of bitcoin adapter#2310
Merged
feat: Allow users to configure logging level of bitcoin adapter#2310
Conversation
viviveevee
requested changes
Jul 5, 2022
ghost
approved these changes
Jul 5, 2022
3 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
The bitcoin adapter's logging can be very verbose if
debuglogging is enabled, making it difficult to make sense of what's going on. On the other hand, these logs are useful for triaging problems.To get the best of both worlds, this commit adds support for an additional configuration option in
dfx.json:By default, a log level of "info" is used, which is relatively quiet. Users can change it to "debug" for more verbose logging.
How Has This Been Tested?
I ran
dfx startwith various configurations ofdfx.jsonand verified from the logs that the bitcoin adapter gets initialized with the expected log level.Checklist: