Skip to content

fix: Provide useful error when provisional_create_canister_with_cycles 404s #2285

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
adamspofford-dfinity merged 5 commits into from
Jun 21, 2022
Merged

fix: Provide useful error when provisional_create_canister_with_cycles 404s #2285

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
3386fb7
Provide useful error when `provisional_create_canister_with_cycles` 404s
adamspofford-dfinity Jun 21, 2022
0e8025f
Add test
adamspofford-dfinity Jun 21, 2022
3bdfb6b
Remove useless step
adamspofford-dfinity Jun 21, 2022
758c6c9
Longer message
adamspofford-dfinity Jun 21, 2022
3281492
Merge branch 'master' into spofford/nowallet-mainnet
mergify[bot] Jun 21, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions e2e/tests-dfx/create.bash
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -230,3 +230,7 @@ teardown() {
assert_command dfx --identity alice canister create --all --controller alice --controller bob
}

@test "canister-create on mainnet without wallet does not propagate the 404" {
assert_command_fail dfx deploy --network ic --no-wallet
assert_match 'dfx ledger create-canister'
}
13 changes: 9 additions & 4 deletions src/dfx/src/lib/operations/canister/create_canister.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,6 +9,7 @@ use crate::lib::waiter::waiter_with_timeout;

use anyhow::{anyhow, bail, Context};
use fn_error_context::context;
use ic_agent::agent_error::HttpErrorPayload;
use ic_agent::AgentError;
use ic_utils::interfaces::ManagementCanister;
use slog::info;
Expand Down Expand Up @@ -85,14 +86,18 @@ pub async fn create_canister(
builder = builder.with_controller(controller);
}
};
builder
let res = builder
.with_optional_compute_allocation(settings.compute_allocation)
.with_optional_memory_allocation(settings.memory_allocation)
.with_optional_freezing_threshold(settings.freezing_threshold)
.call_and_wait(waiter_with_timeout(timeout))
.await
.context("Canister creation call failed.")?
.0
.await;
if let Err(AgentError::HttpError(HttpErrorPayload { status: 404, .. })) = &res {
bail!("In order to create a canister on this network, you must use a wallet in order to allocate cycles to the new canister. \
To do this, remove the --no-wallet argument and try again. It is also possible to create a canister on this network \
using `dfx ledger create-canister`, but doing so will not associate the created canister with any of the canisters in your project.")
}
res.context("Canister creation call failed.")?.0
}
CallSender::Wallet(wallet_id) => {
let wallet = Identity::build_wallet_canister(*wallet_id, env).await?;
Expand Down