Skip to content

Comments

fix: Provide useful error when provisional_create_canister_with_cycles 404s#2285

Merged
adamspofford-dfinity merged 5 commits intomasterfrom
spofford/nowallet-mainnet
Jun 21, 2022
Merged

fix: Provide useful error when provisional_create_canister_with_cycles 404s#2285
adamspofford-dfinity merged 5 commits intomasterfrom
spofford/nowallet-mainnet

Conversation

@adamspofford-dfinity
Copy link
Contributor

@adamspofford-dfinity adamspofford-dfinity commented Jun 21, 2022

Currently, dfx deploy --network ic --no-wallet or dfx canister --network ic create --no-wallet provides this amazingly unhelpful error message:

Error: The replica returned an HTTP Error: Http Error: status 404 Not Found, content type "text/html", content: <html>
<head><title>404 Not Found</title></head>
<body>
<center><h1>404 Not Found</h1></center>
<hr><center>nginx/1.21.3</center>
</body>
</html>

This catches the specific case of 404 on canister creation and provides a more useful error message.

@adamspofford-dfinity adamspofford-dfinity requested a review from a team as a code owner June 21, 2022 18:10
@adamspofford-dfinity adamspofford-dfinity force-pushed the spofford/nowallet-mainnet branch from e5b6262 to 0e8025f Compare June 21, 2022 18:19
@adamspofford-dfinity adamspofford-dfinity changed the title Provide useful error when provisional_create_canister_with_cycles 404s feat: Provide useful error when provisional_create_canister_with_cycles 404s Jun 21, 2022
@adamspofford-dfinity adamspofford-dfinity changed the title feat: Provide useful error when provisional_create_canister_with_cycles 404s fix: Provide useful error when provisional_create_canister_with_cycles 404s Jun 21, 2022
ghost
ghost suggested changes Jun 21, 2022
View reviewed changes
@adamspofford-dfinity adamspofford-dfinity enabled auto-merge (squash) June 21, 2022 19:00
@adamspofford-dfinity adamspofford-dfinity merged commit cf0c0e5 into master Jun 21, 2022
@adamspofford-dfinity adamspofford-dfinity deleted the spofford/nowallet-mainnet branch June 21, 2022 21:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

1 participant

@adamspofford-dfinity