-
Notifications
You must be signed in to change notification settings - Fork 98
fix: Support direct custom build script #2267
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from 2 commits
Commits
Show all changes
16 commits
Select commit
Hold shift + click to select a range
b2cc0fe
Support direct custom build script
adamspofford-dfinity 59853a6
lint
adamspofford-dfinity 78ff7bf
Add explicit error message
adamspofford-dfinity 34574ad
Canonicalize commands against dfx workspace root
adamspofford-dfinity b4fcc84
Update changelog
adamspofford-dfinity 335dda8
Merge branch 'master' into spofford/runscript
adamspofford-dfinity 734969f
fmt
adamspofford-dfinity f1d55e0
Fallback to resolving path against cwd for good errors
adamspofford-dfinity fdee077
Merge branch 'master' into spofford/runscript
adamspofford-dfinity 9786ced
Merge branch 'master' into spofford/runscript
adamspofford-dfinity e02a257
Do them in the opposite order
adamspofford-dfinity b846ae6
Merge branch 'spofford/runscript' of https://github.com/dfinity/sdk i…
adamspofford-dfinity 664b63a
Add test case for local-first behavior
adamspofford-dfinity f2b94a9
Merge branch 'master' into spofford/runscript
adamspofford-dfinity de324b2
shellcheck
adamspofford-dfinity db3734b
Update error_context.bash
adamspofford-dfinity File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,2 @@ | ||
| #!/usr/bin/env bash | ||
| echo CUSTOM_CANISTER2_BUILD_DONE |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.