fix: Support direct custom build script#2267
Merged
adamspofford-dfinity merged 16 commits intomasterfrom Jun 21, 2022
Merged
Conversation
viviveevee
reviewed
Jun 16, 2022
ghost
suggested changes
Jun 16, 2022
ghost
left a comment
ghost
left a comment
There was a problem hiding this comment.
Would you please also add a changelog entry, and describe what this means?
but not "script.sh --args", for the same reason as the shell disallows it in the first place.
ghost
reviewed
Jun 20, 2022
ghost
suggested changes
Jun 20, 2022
ghost
left a comment
ghost
left a comment
There was a problem hiding this comment.
Looks good. Would you please add a test that verifies the expected behavior with respect to custom build commands found both in the project and on the path?
ghost
approved these changes
Jun 21, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Addresses SDK-476. Currently,
type:custom'sbuildflag obeys shell rules, i.e."script.sh"does not work and requires"./script.sh". This changes the behavior to canonicalize the command against the dfx project root, and additionally set the cwd of the script to the project root.