Merged
Conversation
ghost
reviewed
Jun 15, 2022
ghost
reviewed
Jun 15, 2022
ghost
suggested changes
Jun 16, 2022
ghost
reviewed
Jun 16, 2022
ghost
reviewed
Jun 17, 2022
…nto spofford/postbuild
ghost
reviewed
Jun 27, 2022
e2e/tests-dfx/install.bash
Outdated
|
|
||
| echo 'return 1' >> postinstall.sh | ||
| assert_command_fail dfx canister install postinstall_script --mode upgrade | ||
| assert_match hello |
There was a problem hiding this comment.
can you explain why "hello" is expected in the output here?
Contributor
Author
There was a problem hiding this comment.
It's expected because stdout is still printed; it's tested for to ensure that the script is why the command failed.
ghost
reviewed
Jun 27, 2022
ghost
reviewed
Jun 27, 2022
ghost
reviewed
Jun 27, 2022
ghost
approved these changes
Jun 27, 2022
ghost
added
the
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This adds the ability to specify post-installation tasks with a per-canister
post-installkey in dfx.json. Post-installation tasks receive the same environment variables that build tasks do.