Skip to content

docs: update steps for releasing bootstrap-js #1232

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
andrewwylde wants to merge 1 commit into from
Closed

docs: update steps for releasing bootstrap-js #1232

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions .gitignore
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,4 +1,6 @@
result*
agent_js

@andrewwylde andrewwylde Dec 3, 2020

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

So I was thinking it might make more sense to provide -o to the build command so we get a directory for both agent-js and bootstrap-js. Either that, or I think we'd have to do another nix-build after the agent-js was done being published, right?

bootstrap_js

# Building
build/
Expand Down
22 changes: 20 additions & 2 deletions docs/process/release.adoc
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -106,9 +106,11 @@ $dfx_rc cache delete
+
[source, bash]
----
export agent_js_rc="$(nix-build . -A agent-js --option extra-binary-caches https://cache.dfinity.systems)"
export agent_js_rc="$(nix-build . -A agent-js -o agent_js --option extra-binary-caches https://cache.dfinity.systems)"
export bootstrap_js_rc="$(nix-build . -A bootstrap-js -o bootstrap_js --option extra-binary-caches https://cache.dfinity.systems)"
export agent_js_rc_npm_packed="$(sh -c 'echo "$1"' sh $agent_js_rc/dfinity-agent-*.tgz)"


test -f $agent_js_rc_npm_packed \
&& echo 'Please proceed' \
|| echo 'Cannot find npm-packed dfinity-agent-*.tgz'
Expand Down Expand Up @@ -336,6 +338,22 @@ git push origin stable
Pushing the branch second is an optimization.
Hydra will spur into action when `stable` advances, so if the branch is already tagged, it won't require a second fetch.

==== Publish Javascript bootstrap

@andrewwylde andrewwylde Dec 3, 2020

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@hansl definitely want to make sure this makes sense, but wasn't sure how to explain... Should I say "you need to have SSH access to the remote" or will we just have one of those with access do this release part?


. Create and switch to a new directory, then copy html/css/js files from bootstrap source.
[source, nix-shell]
----
pushd $(mktemp -d)
cp -R $bootstrap_js_rc ./
----


. Copy all built files to remote server
[source, nix-shell]
----
rsync -avhP ./dist/ <username>@zh1-ngx01.dfinity.network:/var/www/html

@hansl hansl Jan 6, 2021

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is not publishing bootstrap. It's only for the bootstrap staging environment. We probably want some publishing step for ic0.app proper.

----

==== Publish Javascript agent to NPM

. Create and switch to a new directory to release from by running the following commands:
Expand Down Expand Up @@ -390,7 +408,7 @@ link:https://dfinity.slack.com/archives/CUXGQBABF/p1594954197000100[_#build-noti
about the successful publishing of the dfx tarballs.

. Install the build using the `DFX_VERSION=<version>` environment variable.
. Run through the link:https://staging--eloquent-poitras-af14f0.netlify.app/docs/quickstart/quickstart.html[_Quick start_] steps.
. Run through the link:https://sdk.dfinity.org/docs/quickstart/quickstart.html[_Quick start_] steps.
. Notify link:https://app.slack.com/client/T43F9UHS5/CGA566TPV[#eng-sdk] team members that the new build is ready for manual installation and testing.
. Update the link:https://docs.google.com/spreadsheets/d/1pIblGqIeqapzptOtDb4h0LjJKDFIYXRxJrX9VaphfjA/edit#gid=725289684[_release notes_] spreadsheet and documentation based on the Go/No-go list of merged PRs.
+
Expand Down