Skip to content

docs: update steps for releasing bootstrap-js#1232

Closed
andrewwylde wants to merge 1 commit intomasterfrom
andrewwylde/1606956211
Closed

docs: update steps for releasing bootstrap-js#1232
andrewwylde wants to merge 1 commit intomasterfrom
andrewwylde/1606956211

Conversation

@andrewwylde
Copy link
Contributor

No description provided.

@andrewwylde andrewwylde force-pushed the andrewwylde/1606956211 branch from 7d8ab0e to d600bc3 Compare December 3, 2020 18:17
@@ -1,4 +1,6 @@
result*
agent_js
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

So I was thinking it might make more sense to provide -o to the build command so we get a directory for both agent-js and bootstrap-js. Either that, or I think we'd have to do another nix-build after the agent-js was done being published, right?

Pushing the branch second is an optimization.
Hydra will spur into action when `stable` advances, so if the branch is already tagged, it won't require a second fetch.

==== Publish Javascript bootstrap
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@hansl definitely want to make sure this makes sense, but wasn't sure how to explain... Should I say "you need to have SSH access to the remote" or will we just have one of those with access do this release part?

. Copy all built files to remote server
[source, nix-shell]
----
rsync -avhP ./dist/ <username>@zh1-ngx01.dfinity.network:/var/www/html
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is not publishing bootstrap. It's only for the bootstrap staging environment. We probably want some publishing step for ic0.app proper.

@hansl
Copy link
Contributor

hansl commented Jan 6, 2021

Considering the step described is wrong, I'll close this PR and make an issue on the backlog to update the document for publishing bootstrap.

@hansl hansl closed this Jan 6, 2021
@hansl hansl deleted the andrewwylde/1606956211 branch January 6, 2021 19:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants