Skip to content

docs: clarify in release docs that Firefox Private Browsing wont work and it's fine #1228

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
gobengo wants to merge 2 commits into from
Closed

docs: clarify in release docs that Firefox Private Browsing wont work and it's fine #1228

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
5302271
Clarify in release docs that Firefox Private Browsing wont work and i…
gobengo Dec 2, 2020
1115bd4
remove 'bengo' from @todo
gobengo Jan 20, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 3 additions & 2 deletions docs/process/release.adoc
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -169,9 +169,10 @@ export hello_world_candid_url="http://localhost:8000/candid?canisterId=$($dfx_rc
export hello_world_assets_url="http://localhost:8000/?canisterId=$($dfx_rc canister id hello_world_assets)"

echo "For the next step, open the following URL in your web browser. Be sure to clear your cache first and/or use 'Private Browsing' mode."
echo "@todo: Actually don't worry about Firefox Private Browsing until we resolve: https://github.com/dfinity/sdk/issues/1227"

# This should print the Asset Canister URL you can use to 'Verify hello_world_assets'.
echo "hello_world_assets_url: Open this in your web browser with empty cache or 'Private Browsing' mode"
echo "hello_world_assets_url: Open this in your web browser with empty cache"
echo "$hello_world_assets_url"
----
+
Expand All @@ -191,7 +192,7 @@ To show the URL, run:
[source, bash]
----
# This should print the Candid UI URL you can use to 'Verify hello_world'.
echo "hello_world_candid_url: Open this in your web browser with empty cache or 'Private Browsing' mode"
echo "hello_world_candid_url: Open this in your web browser with empty cache."
echo "$hello_world_candid_url"
----
+
Expand Down