docs: clarify in release docs that Firefox Private Browsing wont work and it's fine#1228
Closed
docs: clarify in release docs that Firefox Private Browsing wont work and it's fine#1228
Conversation
hansl
reviewed
Jan 6, 2021
Contributor
hansl
left a comment
hansl
left a comment
There was a problem hiding this comment.
One nit then I can happily merge this.
docs/process/release.adoc
Outdated
| export hello_world_assets_url="http://localhost:8000/?canisterId=$($dfx_rc canister id hello_world_assets)" | ||
|
|
||
| echo "For the next step, open the following URL in your web browser. Be sure to clear your cache first and/or use 'Private Browsing' mode." | ||
| echo "@todo(bengo): Actually don't worry about Firefox Private Browsing until we resolve: https://github.com/dfinity/sdk/issues/1227" |
Contributor
There was a problem hiding this comment.
I don't personally agree with putting names in a todo, which might move teams or not be the one to fix, and would rather have the Issue number (e.g. dfinity/sdk#1227). We also have git history to know who reported this todo. WDYT?
Contributor
Author
There was a problem hiding this comment.
I agree. I seem to recall some old jsdoc parser that required a name. That's the only reason I include it sometimes. I'll re-train myself to go name-less. Thanks for speaking up about it.
dfinity-bot
added a commit
that referenced
this pull request
Aug 3, 2022
## Changelog for advisory-db: Branch: main Commits: [rustsec/advisory-db@6a31ac74...e0c20907](rustsec/advisory-db@6a31ac7...e0c2090) * [`d8e134f1`](rustsec/advisory-db@d8e134f) Add unmaintained advisory for r2d2-odbc ([RustSec/advisory-db#1150](http://r.duckduckgo.com/l/?uddg=https://github.com/RustSec/advisory-db/issues/1150)) * [`c568a8a3`](rustsec/advisory-db@c568a8a) Fix r2d2_odbc name ([RustSec/advisory-db#1296](http://r.duckduckgo.com/l/?uddg=https://github.com/RustSec/advisory-db/issues/1296)) * [`e4ac884b`](rustsec/advisory-db@e4ac884) Assigned RUSTSEC-2022-0036 to r2d2_odbc ([RustSec/advisory-db#1297](http://r.duckduckgo.com/l/?uddg=https://github.com/RustSec/advisory-db/issues/1297)) * [`259863da`](rustsec/advisory-db@259863d) Add advisories for async-graphql/juniper denial of service issues ([RustSec/advisory-db#1290](http://r.duckduckgo.com/l/?uddg=https://github.com/RustSec/advisory-db/issues/1290)) * [`ec93834e`](rustsec/advisory-db@ec93834) Assigned RUSTSEC-2022-0037 to async-graphql, RUSTSEC-2022-0038 to juniper ([RustSec/advisory-db#1298](http://r.duckduckgo.com/l/?uddg=https://github.com/RustSec/advisory-db/issues/1298)) * [`03872678`](rustsec/advisory-db@0387267) Add unmaintained advisory for odbc ([RustSec/advisory-db#1151](http://r.duckduckgo.com/l/?uddg=https://github.com/RustSec/advisory-db/issues/1151)) * [`a36ba668`](rustsec/advisory-db@a36ba66) Assigned RUSTSEC-2022-0039 to odbc ([RustSec/advisory-db#1299](http://r.duckduckgo.com/l/?uddg=https://github.com/RustSec/advisory-db/issues/1299)) * [`9b48cb22`](rustsec/advisory-db@9b48cb2) sass-rs is deprecated ([RustSec/advisory-db#1228](http://r.duckduckgo.com/l/?uddg=https://github.com/RustSec/advisory-db/issues/1228)) * [`d8dd6280`](rustsec/advisory-db@d8dd628) Assigned RUSTSEC-2021-0136 to sass-rs ([RustSec/advisory-db#1300](http://r.duckduckgo.com/l/?uddg=https://github.com/RustSec/advisory-db/issues/1300)) * [`ff384c3d`](rustsec/advisory-db@ff384c3) Initial advisory for owning_ref unsoundness ([RustSec/advisory-db#1188](http://r.duckduckgo.com/l/?uddg=https://github.com/RustSec/advisory-db/issues/1188)) * [`e0c20907`](rustsec/advisory-db@e0c2090) Assigned RUSTSEC-2022-0040 to owning_ref ([RustSec/advisory-db#1301](http://r.duckduckgo.com/l/?uddg=https://github.com/RustSec/advisory-db/issues/1301))
mergify bot
pushed a commit
that referenced
this pull request
Aug 3, 2022
## Changelog for advisory-db: Branch: main Commits: [rustsec/advisory-db@6a31ac74...e0c20907](rustsec/advisory-db@6a31ac7...e0c2090) * [`d8e134f1`](rustsec/advisory-db@d8e134f) Add unmaintained advisory for r2d2-odbc ([RustSec/advisory-db#1150](http://r.duckduckgo.com/l/?uddg=https://github.com/RustSec/advisory-db/issues/1150)) * [`c568a8a3`](rustsec/advisory-db@c568a8a) Fix r2d2_odbc name ([RustSec/advisory-db#1296](http://r.duckduckgo.com/l/?uddg=https://github.com/RustSec/advisory-db/issues/1296)) * [`e4ac884b`](rustsec/advisory-db@e4ac884) Assigned RUSTSEC-2022-0036 to r2d2_odbc ([RustSec/advisory-db#1297](http://r.duckduckgo.com/l/?uddg=https://github.com/RustSec/advisory-db/issues/1297)) * [`259863da`](rustsec/advisory-db@259863d) Add advisories for async-graphql/juniper denial of service issues ([RustSec/advisory-db#1290](http://r.duckduckgo.com/l/?uddg=https://github.com/RustSec/advisory-db/issues/1290)) * [`ec93834e`](rustsec/advisory-db@ec93834) Assigned RUSTSEC-2022-0037 to async-graphql, RUSTSEC-2022-0038 to juniper ([RustSec/advisory-db#1298](http://r.duckduckgo.com/l/?uddg=https://github.com/RustSec/advisory-db/issues/1298)) * [`03872678`](rustsec/advisory-db@0387267) Add unmaintained advisory for odbc ([RustSec/advisory-db#1151](http://r.duckduckgo.com/l/?uddg=https://github.com/RustSec/advisory-db/issues/1151)) * [`a36ba668`](rustsec/advisory-db@a36ba66) Assigned RUSTSEC-2022-0039 to odbc ([RustSec/advisory-db#1299](http://r.duckduckgo.com/l/?uddg=https://github.com/RustSec/advisory-db/issues/1299)) * [`9b48cb22`](rustsec/advisory-db@9b48cb2) sass-rs is deprecated ([RustSec/advisory-db#1228](http://r.duckduckgo.com/l/?uddg=https://github.com/RustSec/advisory-db/issues/1228)) * [`d8dd6280`](rustsec/advisory-db@d8dd628) Assigned RUSTSEC-2021-0136 to sass-rs ([RustSec/advisory-db#1300](http://r.duckduckgo.com/l/?uddg=https://github.com/RustSec/advisory-db/issues/1300)) * [`ff384c3d`](rustsec/advisory-db@ff384c3) Initial advisory for owning_ref unsoundness ([RustSec/advisory-db#1188](http://r.duckduckgo.com/l/?uddg=https://github.com/RustSec/advisory-db/issues/1188)) * [`e0c20907`](rustsec/advisory-db@e0c2090) Assigned RUSTSEC-2022-0040 to owning_ref ([RustSec/advisory-db#1301](http://r.duckduckgo.com/l/?uddg=https://github.com/RustSec/advisory-db/issues/1301))
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.