build: prebuild binary_cache and assetstorage canister asset archives#1061
Merged
mergify[bot] merged 2 commits intomasterfrom Sep 25, 2020
Merged
build: prebuild binary_cache and assetstorage canister asset archives#1061mergify[bot] merged 2 commits intomasterfrom
mergify[bot] merged 2 commits intomasterfrom
Conversation
hansl
approved these changes
Sep 24, 2020
dfinity-bot
added a commit
that referenced
this pull request
Sep 29, 2021
## Changelog for advisory-db: Branch: main Commits: [rustsec/advisory-db@653bd139...f2e3a650](rustsec/advisory-db@653bd13...f2e3a65) * [`a44ad8fa`](rustsec/advisory-db@a44ad8f) Clarify meaning of RUSTSEC-2021-0077.md ([RustSec/advisory-db#1061](http://r.duckduckgo.com/l/?uddg=https://github.com/RustSec/advisory-db/issues/1061)) * [`9cc82e1b`](rustsec/advisory-db@9cc82e1) arrow BinaryArray advisory ([RustSec/advisory-db#1057](http://r.duckduckgo.com/l/?uddg=https://github.com/RustSec/advisory-db/issues/1057)) * [`a7d4ec8d`](rustsec/advisory-db@a7d4ec8) Assigned RUSTSEC-2021-0116 to arrow ([RustSec/advisory-db#1062](http://r.duckduckgo.com/l/?uddg=https://github.com/RustSec/advisory-db/issues/1062)) * [`edfbe64d`](rustsec/advisory-db@edfbe64) arrow DecimalArray advisory ([RustSec/advisory-db#1058](http://r.duckduckgo.com/l/?uddg=https://github.com/RustSec/advisory-db/issues/1058)) * [`a9bf4727`](rustsec/advisory-db@a9bf472) Assigned RUSTSEC-2021-0117 to arrow ([RustSec/advisory-db#1063](http://r.duckduckgo.com/l/?uddg=https://github.com/RustSec/advisory-db/issues/1063)) * [`f2e3a650`](rustsec/advisory-db@f2e3a65) Yet another arrow advisory ([RustSec/advisory-db#1059](http://r.duckduckgo.com/l/?uddg=https://github.com/RustSec/advisory-db/issues/1059))
mergify bot
pushed a commit
that referenced
this pull request
Sep 29, 2021
## Changelog for advisory-db: Branch: main Commits: [rustsec/advisory-db@653bd139...f2e3a650](rustsec/advisory-db@653bd13...f2e3a65) * [`a44ad8fa`](rustsec/advisory-db@a44ad8f) Clarify meaning of RUSTSEC-2021-0077.md ([RustSec/advisory-db#1061](http://r.duckduckgo.com/l/?uddg=https://github.com/RustSec/advisory-db/issues/1061)) * [`9cc82e1b`](rustsec/advisory-db@9cc82e1) arrow BinaryArray advisory ([RustSec/advisory-db#1057](http://r.duckduckgo.com/l/?uddg=https://github.com/RustSec/advisory-db/issues/1057)) * [`a7d4ec8d`](rustsec/advisory-db@a7d4ec8) Assigned RUSTSEC-2021-0116 to arrow ([RustSec/advisory-db#1062](http://r.duckduckgo.com/l/?uddg=https://github.com/RustSec/advisory-db/issues/1062)) * [`edfbe64d`](rustsec/advisory-db@edfbe64) arrow DecimalArray advisory ([RustSec/advisory-db#1058](http://r.duckduckgo.com/l/?uddg=https://github.com/RustSec/advisory-db/issues/1058)) * [`a9bf4727`](rustsec/advisory-db@a9bf472) Assigned RUSTSEC-2021-0117 to arrow ([RustSec/advisory-db#1063](http://r.duckduckgo.com/l/?uddg=https://github.com/RustSec/advisory-db/issues/1063)) * [`f2e3a650`](rustsec/advisory-db@f2e3a65) Yet another arrow advisory ([RustSec/advisory-db#1059](http://r.duckduckgo.com/l/?uddg=https://github.com/RustSec/advisory-db/issues/1059))
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
It turns out that it takes ~99 seconds to build
binary_cache.tgzfrom the contents of the directory at$DFX_ASSETS.This change builds both
binary_cache.tgzandassetstorage_canister.tgzonce pernix-build, rather than once percargo build.The remaining
.tgzarchives are still built atcargo buildtime, but they only take a handful of milliseconds to build.Please note that the trick of pointing $DFX_ASSETS at an empty directory (for cargo check) will no longer work, but it is also no longer necessary.
These were the times observed to build these files prior to this change:
After: (I didn't bother to break it down by file)
This also removes
fn add_optional_assetsbecause we no longer builddfxin two stages.