Skip to content

feat: update management canister interface #29

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
chenyan-dfinity wants to merge 3 commits into from
Closed

feat: update management canister interface #29

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
3187b57
update management canister interface
chenyan-dfinity Sep 18, 2020
ffd7159
fix
chenyan-dfinity Sep 18, 2020
d103e9c
update asset idl
chenyan-dfinity Sep 22, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion packages/agent/src/actor.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -332,7 +332,7 @@ async function _requestStatusAndLoop<T>(
// we don't know the result and cannot decode it.
throw new Error(
`Call was marked as done but we never saw the reply:\n` +
` Request ID: ${requestIdToHex(requestId)}\n`
` Request ID: ${requestIdToHex(requestId)}\n`,
);
}
}
Expand Down
1 change: 1 addition & 0 deletions packages/agent/src/canisters/asset.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,6 +5,7 @@ import assetCanister from './asset_idl';
export interface AssetCanisterRecord {
store(path: string, content: number[]): Promise<void>;
retrieve(path: string): Promise<number[]>;
list(): Promise<string[]>;
}
/* tslint:enable */

Expand Down
1 change: 1 addition & 0 deletions packages/agent/src/canisters/asset_idl.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,5 +7,6 @@ export default ({ IDL }) => {
return IDL.Service({
retrieve: IDL.Func([IDL.Text], [IDL.Vec(IDL.Nat8)], ['query']),
store: IDL.Func([IDL.Text, IDL.Vec(IDL.Nat8)], [], []),
list: IDL.Func([], [IDL.Vec(IDL.Text)], ['query']),
Copy link
Contributor

@hansl hansl Oct 7, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is there a list in the actual asset canister? That doesn't seem like a good idea...

Copy link
Contributor Author

@chenyan-dfinity chenyan-dfinity Oct 7, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It is added here: dfinity/sdk#1047. What's the concern for list?

});
};
47 changes: 37 additions & 10 deletions packages/agent/src/canisters/management_idl.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,31 +1,58 @@
/**
* This file is generated from the candid for asset management.
* This file is generated from public spec 0.10.
* didc bind ic.did -t js
*/
/* tslint:disable */
// @ts-ignore
export default ({ IDL }) => {
const canister_id = IDL.Principal;
const wasm_module = IDL.Vec(IDL.Nat8);
return IDL.Service({
create_canister: IDL.Func([], [IDL.Record({ canister_id: canister_id })], []),
install_code: IDL.Func(
stop_canister: IDL.Func([IDL.Record({ canister_id: canister_id })], [], []),
start_canister: IDL.Func([IDL.Record({ canister_id: canister_id })], [], []),
canister_status: IDL.Func(
[IDL.Record({ canister_id: canister_id })],
[
IDL.Record({
status: IDL.Variant({
stopped: IDL.Null,
stopping: IDL.Null,
running: IDL.Null,
}),
}),
],
[],
),
delete_canister: IDL.Func([IDL.Record({ canister_id: canister_id })], [], []),
set_controller: IDL.Func(
[
IDL.Record({
mode: IDL.Variant({ install: IDL.Null, reinstall: IDL.Null, upgrade: IDL.Null }),
canister_id: canister_id,
wasm_module: wasm_module,
arg: IDL.Vec(IDL.Nat8),
compute_allocation: IDL.Opt(IDL.Nat),
memory_allocation: IDL.Opt(IDL.Nat),
new_controller: IDL.Principal,
}),
],
[],
[],
),
set_controller: IDL.Func(
[IDL.Record({ canister_id: canister_id, new_controller: IDL.Principal })],
install_code: IDL.Func(
[
IDL.Record({
arg: IDL.Vec(IDL.Nat8),
wasm_module: wasm_module,
mode: IDL.Variant({
reinstall: IDL.Null,
upgrade: IDL.Null,
install: IDL.Null,
}),
canister_id: canister_id,
memory_allocation: IDL.Opt(IDL.Nat),
compute_allocation: IDL.Opt(IDL.Nat),
Copy link

@sasa-tomic sasa-tomic Sep 22, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is already out of date: query_allocation is missing. Things are moving fast. https://github.com/dfinity-lab/dfinity/blob/4ce24419adc98dce26b1f1e62f1b2e1a63bf7f3f/rs/types/src/ic00.rs#L85

Copy link
Contributor Author

@chenyan-dfinity chenyan-dfinity Sep 22, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's not in the spec. We are generating from spec 0.10: https://github.com/dfinity-lab/ic-ref/blob/release-0.10/spec/ic.did

}),
],
[],
[],
),
raw_rand: IDL.Func([], [IDL.Vec(IDL.Nat8)], []),
create_canister: IDL.Func([], [IDL.Record({ canister_id: canister_id })], []),
});
};