feat: update management canister interface#29
Conversation
|
Is this still Draft? |
| }), | ||
| canister_id: canister_id, | ||
| memory_allocation: IDL.Opt(IDL.Nat), | ||
| compute_allocation: IDL.Opt(IDL.Nat), |
There was a problem hiding this comment.
This is already out of date: query_allocation is missing. Things are moving fast. https://github.com/dfinity-lab/dfinity/blob/4ce24419adc98dce26b1f1e62f1b2e1a63bf7f3f/rs/types/src/ic00.rs#L85
There was a problem hiding this comment.
It's not in the spec. We are generating from spec 0.10: https://github.com/dfinity-lab/ic-ref/blob/release-0.10/spec/ic.did
|
@sasa-tomic What will happen if this runs against the release the replica on tungsten is running today? |
Good question @gobengo , I would expect it to work, although TBH I don't know how to test. |
|
It should break client code, but due to several pending issues, everything works fine by luck, see https://github.com/dfinity-lab/dfinity/pull/5258#discussion_r484888797. |
| return IDL.Service({ | ||
| retrieve: IDL.Func([IDL.Text], [IDL.Vec(IDL.Nat8)], ['query']), | ||
| store: IDL.Func([IDL.Text, IDL.Vec(IDL.Nat8)], [], []), | ||
| list: IDL.Func([], [IDL.Vec(IDL.Text)], ['query']), |
There was a problem hiding this comment.
Is there a list in the actual asset canister? That doesn't seem like a good idea...
There was a problem hiding this comment.
It is added here: dfinity/sdk#1047. What's the concern for list?
|
@chenyan-dfinity This PR has been chilling here since October. Does this still need to happen? |
|
It's probably out-dated, I will close it. But it would be nice to update the management canister interface. We only have a small subset of the real ic interface in agent-js. |
5 participants
No description provided.