Skip to content

Conversation

@basvandijk
Copy link
Collaborator

@basvandijk basvandijk commented May 28, 2025

This is a cherry-pick of #5347 onto #5194.

The ledger_suite_orchestrator_canister is using a proc-macro from the aksama crate:

#[derive(Template)]
#[template(path = "dashboard.html")]
pub struct DashboardTemplate { ... }

This is known to cause non-determinism (askama-rs/askama#461) and it's causing the Build Reproducibility check to fail in: https://github.com/dfinity/ic/actions/runs/15296835171/job/43032042139?pr=5194. It's unclear why it didn't fail earlier.

We therefor apply the same work-around as in: rs/http_endpoints/public/build.rs and rs/ic_os/config/build.rs by loading the template in build.rs from a string instead of from a path.

@github-actions github-actions bot added the fix label May 28, 2025
@basvandijk basvandijk changed the title fix: ensure reproducibility of the ledger_suite_orchestrator_canister fix: ensure reproducibility of the ledger_suite_orchestrator_canister (stacked) May 28, 2025
Base automatically changed from sat-revert-rust-1.86 to master June 2, 2025 18:51
@basvandijk basvandijk closed this Jun 10, 2025
@basvandijk basvandijk deleted the sat-revert-rust-1.86-fix-build-determinism branch June 10, 2025 10:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants