Skip to content

chore: Update Rust to 1.86.0 #5059

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
sasa-tomic merged 46 commits into from
May 13, 2025
Merged

chore: Update Rust to 1.86.0 #5059

sasa-tomic merged 46 commits into from
May 13, 2025

Conversation

@sasa-tomic
Copy link
Contributor

@sasa-tomic sasa-tomic commented May 9, 2025 •
edited by basvandijk
Loading

Upgrade the rust toolchain from 1.85.1 to 1.86.0.

Note there were the following WASM instruction regressions:

Executing tests from //rs/nns/governance:governance-canbench_test
-----------------------------------------------------------------------------

Benchmark: compute_ballots_for_new_proposal_with_stable_neurons
  total:
    instructions: 1.88 M (regressed by 5.22%)
    heap_increase: 0 pages (no change)
    stable_memory_increase: 0 pages (no change)

---------------------------------------------------

Benchmark: list_ready_to_spawn_neuron_ids_stable
  total:
    instructions: 37.35 M (regressed by 6.15%)
    heap_increase: 0 pages (no change)
    stable_memory_increase: 0 pages (no change)

---------------------------------------------------

Benchmark: unstake_maturity_of_dissolved_neurons_stable
  total:
    instructions: 64.54 M (regressed by 5.54%)
    heap_increase: 0 pages (no change)
    stable_memory_increase: 0 pages (no change)

  list_neuron_ids (scope):
    instructions: 38.80 M (regressed by 6.27%)
    heap_increase: 0 pages (no change)
    stable_memory_increase: 0 pages (no change)

---------------------------------------------------

Benchmark: draw_maturity_from_neurons_fund_stable
  total:
    instructions: 7.53 M (regressed by 6.31%)
    heap_increase: 0 pages (no change)
    stable_memory_increase: 0 pages (no change)

---------------------------------------------------

sasa-tomic and others added 30 commits March 12, 2025 15:18
@sasa-tomic
chore!: update Rust version to 1.85.0 and deduplicate code
f24f7ac 
- **Rust Version**: Update Rust toolchain and Bazel configuration to Rust 1.85.0.
- **Refactoring**:
  - Remove redundant `map` and `map_err` methods where conversion is unnecessary.
  - Simplify bitwise operations with clearer grouping.
- **Tests and Comments**: Updated relevant tests and comments.
Updating container image to sha256:1de2eef8662eb58cbb911b844bb0afcc19…
4bf3e2f 
…ba89009272f40803a49640211565e7

Image tag: 840f94ead19b1ae2da20554e111b7ca9ab0fe37e76c42b0dd06e69f370df73a0
@basvandijk
rules_rust: 0.56.0 -> 0.59.0
afbd9ab
@sasa-tomic
Getting replica compiled
eda3e7c
@sasa-tomic
rustfmt
0149d7e
@basvandijk
Merge remote-tracking branch 'origin/master' into update-rust-and-ref…
961fd85 
…actor-code
Automatically updated Cargo*.lock
3bb8bf6
Updating container image to sha256:25418a8378ec359093ea1e56cae328b423…
be36550 
…50154e6990d8f6e8c3233d5e55d047

Image tag: f8a14ee2eb1c108f88c3644289709b7e9dbd12d2609bd365e13f4c508d96b3b9
@sasa-tomic
Remove obsolete documentation comments
783fc56
@basvandijk
Upgrade rules_rust: 0.59.0 -> 0.59.2 and rustc: 1.85.0 -> 1.85.1
de4bc40
@basvandijk
Try to fix the `Repository '@@rules_rust_ctve__toml-0.8.20' is not de…
3783727 
…fined` error
@basvandijk
rust-toolchain.toml: update rust version
7af868a
Updating container image to sha256:245b3fa0d81666579d3ec8f016272f9a37…
fefb737 
…db39dc42e2b1f35a16b88576118a44

Image tag: ac31c084e55f4b4d3d857b8369ba7bba73721b446fff9496f72b3edcbe8df291
@basvandijk
chore(IDX): rules_rust: 0.56.0 -> 0.59.2
39480ac
@basvandijk
Upgrade platforms: 0.0.10 -> 0.0.11
afa77a6
@basvandijk
bazel run //bazel:buildifier
83fae93
@basvandijk
bazel run //bazel:buildifier
05d162e
@basvandijk
Use older rust nightly to work around fuzzing issue
824ca1a
@basvandijk
Merge remote-tracking branch 'origin/master' into update-rust-and-ref…
b944534 
…actor-code
@basvandijk
bin/bazel-pin.sh --force
da397d3
@basvandijk
clippy
018b1cb
@basvandijk
Merge branch 'master' into update-rust-and-refactor-code
08dafa4
@basvandijk
Merge branch 'master' into update-rust-and-refactor-code
72f7db7
@sasa-tomic
Merge branch 'master' into update-rust-and-refactor-code
82d0872
@sasa-tomic
repin
a4963fe
Updating container image to sha256:efe6edcd9a9e169843a02f91af98b29514…
9763fd6 
…c00cda858ad6612cda28b231b80896

Image tag: 3426fa29677ab9de5778c28c093194f9a45946bfaa7b910d0fc0bfa893e2a13a
@basvandijk
Merge remote-tracking branch 'origin/master' into basvandijk/rules_ru…
c7d9184 
…st-0.59.2
@sasa-tomic
Merge branch 'master' into update-rust-and-refactor-code
29d61e7
@sasa-tomic
Merge remote-tracking branch 'origin/basvandijk/rules_rust-0.59.2' in…
e4761b4 
…to update-rust-and-refactor-code
@sasa-tomic
clippy
a29bba3
@sasa-tomic sasa-tomic dismissed github-actions[bot]’s stale review May 12, 2025 12:26

No canister behavior changes.

@kpop-dfinity
Copy link
Contributor

kpop-dfinity commented May 12, 2025

Thanks, Sasa!

max-dfinity
max-dfinity reviewed May 12, 2025
View reviewed changes
@sasa-tomic sasa-tomic enabled auto-merge May 13, 2025 08:19
@sasa-tomic sasa-tomic added this pull request to the merge queue May 13, 2025
Merged via the queue into master with commit d1dc4c2 May 13, 2025
25 checks passed
@sasa-tomic sasa-tomic deleted the sat-update-rust-1-86 branch May 13, 2025 09:09
sasa-tomic added a commit that referenced this pull request May 19, 2025
@sasa-tomic
Revert "chore: Update Rust to 1.86.0 (#5059)"
51de7ac 
This reverts commit d1dc4c2.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@basvandijk basvandijk basvandijk approved these changes

@mraszyk mraszyk mraszyk approved these changes

@fspreiss fspreiss fspreiss approved these changes

@schneiderstefan schneiderstefan schneiderstefan approved these changes

@blind-oracle blind-oracle blind-oracle approved these changes

@mducroux mducroux mducroux approved these changes

@frankdavid frankdavid frankdavid approved these changes

@mbjorkqvist mbjorkqvist mbjorkqvist approved these changes

@r-birkner r-birkner r-birkner approved these changes

@kpop-dfinity kpop-dfinity kpop-dfinity approved these changes

@github-actions github-actions[bot] github-actions[bot] left review comments

+4 more reviewers

@AlexandraZapuc AlexandraZapuc AlexandraZapuc approved these changes

@ShuoWangNSL ShuoWangNSL ShuoWangNSL approved these changes

@max-dfinity max-dfinity max-dfinity approved these changes

@altkdf altkdf altkdf approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

@boundary-node chore @consensus @cross-chain-team @crypto-team @execution @finint @ic-interface-owners @ic-message-routing-owners @idx @nns-team @node @pocket-ic

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.