refactor: add `alloy` feature flag to `evm_rpc_client` by lpahlavi · Pull Request #484 · dfinity/evm-rpc-canister

lpahlavi · 2025-09-26T11:38:09Z

(XC-412)Add an alloy feature flag to the evm_rpc_client crate. When enabled, the client returns alloy output types from the EVM RPC canister; otherwise, it returns the default Candid types.

evm_rpc_client/src/request/mod.rs

gregorydemay

Thanks for all the improvements @lpahlavi !

evm_rpc_client/Cargo.toml

evm_rpc_client/src/request/mod.rs

Co-authored-by: gregorydemay <112856886+gregorydemay@users.noreply.github.com>

…verter` impls

…lloy-feature-flag

lpahlavi

Thanks a lot for the review and feedback @gregorydemay! This should be ready for another round 🚀

evm_rpc_client/Cargo.toml

evm_rpc_client/src/request/mod.rs

evm_rpc_client/src/lib.rs

evm_rpc_types/src/tests.rs

tests/tests.rs

lpahlavi

Thanks a lot @gregorydemay for the review and apologies for the late reply! I've unified the Alloy and Candid integration tests so I believe this should be ready for another round.

evm_rpc_client/src/lib.rs

evm_rpc_types/src/tests.rs

tests/tests.rs

gregorydemay

Thanks for all the hard work @lpahlavi ! One last minor comment regarding using From conversion but otherwise LGTM!

tests/tests.rs

## 🤖 New release * `evm_rpc_types`: 2.1.0 -> 3.0.0 (✓ API compatible changes) * `evm_rpc_client`: 0.1.0 * `evm_rpc`: 2.5.0 -> 2.6.0 (✓ API compatible changes) <details><summary>Changelog</summary> ## `evm_rpc_types` <blockquote> ## [3.0.0] - 2025-10-20 ### Added - Add conversions between several types in this crate and the corresponding `alloy` types. These conversions are only available with the `alloy` feature ([#465](#465), [#466](#466), [#467](#467), [#476](#476)). - **Breaking:** Add `root` and `cumulativeGasUsed` fields to `TransactionsReceipt` type ([#474](#474)) [3.0.0]: https://github.com/dfinity/evm-rpc-canister/compare/evm_rpc_types-v2.1.0..evm_rpc_types-v3.0.0 </blockquote> ## `evm_rpc_client` <blockquote> ## [0.1.0] - 2025-10-20 ### Added - Add methods to modify RPC config to `RequestBuilder` ([#494](#494)) - Add `alloy` feature flag to `evm_rpc_client` ([#484](#484)) - Add new `json_request` endpoint ([#477](#477)) - Add client support for `eth_getTransactionReceipt` ([#476](#476)) - Add `eth_sendRawTransaction` client support ([#467](#467)) - Add client support for `eth_call` ([#466](#466)) - Add client support for `eth_getTransactionCount` ([#465](#465)) - Add support for `eth_feeHistory` to client ([#460](#460)) - Add support for `eth_getBlockByNumber` to client ([#459](#459)) - Add EVM RPC canister client ([#447](#447)) [0.1.0]: https://github.com/dfinity/evm-rpc-canister/releases/tag/evm_rpc_client-v0.1.0 </blockquote> ## `evm_rpc` <blockquote> ## [2.6.0] - 2025-10-20 ### Added - Add support for `root` and `cumulativeGasUsed` fields in `eth_getTransactionReceipt` response ([#474](#474)) - Add new `json_request` endpoint and deprecate existing `request` endpoint ([#477](#477)) ### Changed - Update `ic-cdk` to `v0.18.7` ([#489](#489)) - Update `dfx` to `v0.29.0` ([#490](#490)) - Cleanup unused dependencies ([#491](#491)) ### Removed - **Breaking**: Remove `getMetrics` endpoint, this is acceptable since it was a debugging endpoint ([#479](#479)) ### Fixed - Add `err_max_response_size_exceeded` to Prometheus metrics ([#487](#487)) [2.6.0]: v2.5.0...v2.6.0 </blockquote> </details> --- This PR was generated with [release-plz](https://github.com/release-plz/release-plz/). --------- Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com> Co-authored-by: Louis Pahlavi <louis.pahlavi@dfinity.org>

## 🤖 New release * `evm_rpc_types`: 2.1.0 -> 3.0.0 (✓ API compatible changes) * `evm_rpc_client`: 0.1.0 * `evm_rpc`: 2.5.0 -> 2.6.0 (✓ API compatible changes) <details><summary>Changelog</summary> ## `evm_rpc_types` <blockquote> ## [3.0.0] - 2025-10-20 ### Added - Add conversions between several types in this crate and the corresponding `alloy` types. These conversions are only available with the `alloy` feature ([#465](dfinity/evm-rpc-canister#465), [#466](dfinity/evm-rpc-canister#466), [#467](dfinity/evm-rpc-canister#467), [#476](dfinity/evm-rpc-canister#476)). - **Breaking:** Add `root` and `cumulativeGasUsed` fields to `TransactionsReceipt` type ([#474](dfinity/evm-rpc-canister#474)) [3.0.0]: https://github.com/dfinity/evm-rpc-canister/compare/evm_rpc_types-v2.1.0..evm_rpc_types-v3.0.0 </blockquote> ## `evm_rpc_client` <blockquote> ## [0.1.0] - 2025-10-20 ### Added - Add methods to modify RPC config to `RequestBuilder` ([#494](dfinity/evm-rpc-canister#494)) - Add `alloy` feature flag to `evm_rpc_client` ([#484](dfinity/evm-rpc-canister#484)) - Add new `json_request` endpoint ([#477](dfinity/evm-rpc-canister#477)) - Add client support for `eth_getTransactionReceipt` ([#476](dfinity/evm-rpc-canister#476)) - Add `eth_sendRawTransaction` client support ([#467](dfinity/evm-rpc-canister#467)) - Add client support for `eth_call` ([#466](dfinity/evm-rpc-canister#466)) - Add client support for `eth_getTransactionCount` ([#465](dfinity/evm-rpc-canister#465)) - Add support for `eth_feeHistory` to client ([#460](dfinity/evm-rpc-canister#460)) - Add support for `eth_getBlockByNumber` to client ([#459](dfinity/evm-rpc-canister#459)) - Add EVM RPC canister client ([#447](dfinity/evm-rpc-canister#447)) [0.1.0]: https://github.com/dfinity/evm-rpc-canister/releases/tag/evm_rpc_client-v0.1.0 </blockquote> ## `evm_rpc` <blockquote> ## [2.6.0] - 2025-10-20 ### Added - Add support for `root` and `cumulativeGasUsed` fields in `eth_getTransactionReceipt` response ([#474](dfinity/evm-rpc-canister#474)) - Add new `json_request` endpoint and deprecate existing `request` endpoint ([#477](dfinity/evm-rpc-canister#477)) ### Changed - Update `ic-cdk` to `v0.18.7` ([#489](dfinity/evm-rpc-canister#489)) - Update `dfx` to `v0.29.0` ([#490](dfinity/evm-rpc-canister#490)) - Cleanup unused dependencies ([#491](dfinity/evm-rpc-canister#491)) ### Removed - **Breaking**: Remove `getMetrics` endpoint, this is acceptable since it was a debugging endpoint ([#479](dfinity/evm-rpc-canister#479)) ### Fixed - Add `err_max_response_size_exceeded` to Prometheus metrics ([#487](dfinity/evm-rpc-canister#487)) [2.6.0]: dfinity/evm-rpc-canister@v2.5.0...v2.6.0 </blockquote> </details> --- This PR was generated with [release-plz](https://github.com/release-plz/release-plz/). --------- Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com> Co-authored-by: Louis Pahlavi <louis.pahlavi@dfinity.org>

lpahlavi added 8 commits September 23, 2025 21:27

XC-412: Remove EvmRpcSetup::request method

eb86813

XC-412: Remove blocking EvmRpcSetup

d78a8bb

XC-412: Rename EvmRpcNonblockingSetup

08fca95

Remove getMetrics endpoint

48f5a14

Merge branch 'main' into lpahlavi/remove-get-metrics-endpoint

7753b21

XC-412: Add json_request to EVM RPC canister

27fb2c2

XC-412: Revert unnecessary changes

4bae381

XC-412: Fix response ID

97a712e

lpahlavi changed the base branch from main to lpahlavi/XC-412-add-raw-request September 26, 2025 11:38

XC-412: Add feature flag to enable alloy

c478ad8

lpahlavi force-pushed the lpahlavi/XC-412-alloy-feature-flag branch from 9173715 to c478ad8 Compare September 26, 2025 11:39

lpahlavi requested a review from gregorydemay September 26, 2025 12:02

lpahlavi marked this pull request as ready for review September 26, 2025 12:02

lpahlavi requested a review from a team as a code owner September 26, 2025 12:02

gregorydemay reviewed Sep 26, 2025

View reviewed changes

evm_rpc_client/src/request/mod.rs Outdated Show resolved Hide resolved

lpahlavi requested a review from gregorydemay September 26, 2025 13:08

lpahlavi added 2 commits September 26, 2025 15:59

XC-412: Remove EvmRpcRequest::Output

bab3c2b

XC-412: Format

664ed9f

lpahlavi marked this pull request as draft September 26, 2025 15:26

lpahlavi added 2 commits September 29, 2025 09:38

XC-412: Add EvmRpcResponseConverter trait

50bda83

XC-412: Clippy

87d13d9

lpahlavi marked this pull request as ready for review September 29, 2025 14:42

gregorydemay reviewed Sep 30, 2025

View reviewed changes

lpahlavi and others added 7 commits September 30, 2025 10:46

Merge branch 'main' into lpahlavi/XC-412-add-raw-request

ccd2866

XC-412: Keep json variable name in Candid

e1ecaf4

Co-authored-by: gregorydemay <112856886+gregorydemay@users.noreply.github.com>

XC-412: Rename json_request to multi_request

f8f19e4

XC-412: Add some doc to multi_request in Candid file

87cd469

XC-412: Fix ResponseTransform::Raw

e6da55b

XC-412: Add RawJson wrapper for String

003ebaa

XC-412: Add metrics label for manual requests

caf1526

lpahlavi added 8 commits September 30, 2025 11:57

XC-412: Add note about ID being overwritten

de85525

XC-412: Clippy

471fd8d

XC-412: Change RpcMethod::Custom to hold String

c183f06

XC-412: Add is_manual_request="true" to metrics assertions

0d3a318

XC-412: Move AlloyResponseConverter to separate file

91a056d

XC-412: Don't use EvmRpcRequest::CandidOutput in `EvmRpcResponseCon…

e6d4a02

…verter` impls

Merge branch 'lpahlavi/XC-412-add-raw-request' into lpahlavi/XC-412-a…

a0aef0f

…lloy-feature-flag

XC-412: Clippy

b843836

lpahlavi commented Sep 30, 2025

View reviewed changes

evm_rpc_client/Cargo.toml Outdated Show resolved Hide resolved

evm_rpc_client/src/request/mod.rs Outdated Show resolved Hide resolved

evm_rpc_client/src/request/mod.rs Show resolved Hide resolved

lpahlavi requested a review from gregorydemay September 30, 2025 12:38

Base automatically changed from lpahlavi/XC-412-add-raw-request to main October 1, 2025 06:45

lpahlavi added 4 commits October 1, 2025 09:30

Merge branch 'main' into lpahlavi/XC-412-alloy-feature-flag

9599dda

XC-412: Add integration tests for Candid response types

8f5c1d5

XC-412: Clippy

79c9512

XC-412: Clean-up MultiRpcResult imports in doc

00404d9

lpahlavi commented Oct 1, 2025

View reviewed changes

evm_rpc_client/src/lib.rs Show resolved Hide resolved

gregorydemay reviewed Oct 2, 2025

View reviewed changes

evm_rpc_types/src/tests.rs Show resolved Hide resolved

tests/tests.rs Outdated Show resolved Hide resolved

XC-502: Combine Candid and Alloy tests

266bc72

lpahlavi commented Oct 6, 2025

View reviewed changes

evm_rpc_client/src/lib.rs Show resolved Hide resolved

evm_rpc_types/src/tests.rs Show resolved Hide resolved

tests/tests.rs Outdated Show resolved Hide resolved

lpahlavi requested a review from gregorydemay October 6, 2025 10:03

XC-502: Fixup: delete test

cefeb12

gregorydemay approved these changes Oct 6, 2025

View reviewed changes

tests/tests.rs Show resolved Hide resolved

XC-502: Streamline expected result definitions

d08a653

lpahlavi merged commit f977230 into main Oct 6, 2025
12 checks passed

lpahlavi deleted the lpahlavi/XC-412-alloy-feature-flag branch October 6, 2025 13:58

This was referenced Oct 20, 2025

chore: release #499

Closed

chore: release #500

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

refactor: add `alloy` feature flag to `evm_rpc_client`#484

refactor: add `alloy` feature flag to `evm_rpc_client`#484
lpahlavi merged 35 commits intomainfrom
lpahlavi/XC-412-alloy-feature-flag

lpahlavi commented Sep 26, 2025

Uh oh!

Uh oh!

gregorydemay left a comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

lpahlavi left a comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

lpahlavi left a comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

gregorydemay left a comment

Uh oh!

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

Conversation

lpahlavi commented Sep 26, 2025

Uh oh!

Uh oh!

gregorydemay left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

lpahlavi left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

lpahlavi left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

gregorydemay left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants