feat: add client support for `eth_getTransactionCount` by lpahlavi · Pull Request #465 · dfinity/evm-rpc-canister

lpahlavi · 2025-09-08T15:04:52Z

(XC-412) Add support to the EVM RPC client for the eth_getTransactionCount endpoint.

gregorydemay

Thanks @lpahlavi ! some minor comments but otherwise looks very good to me!

tests/mock_http_runtime/mod.rs

tests/setup/mod.rs

gregorydemay · 2025-09-15T07:51:47Z

tests/setup/mod.rs

+            self.canister_id,
+        )
    }



Here for a lack of a better place: It's important that updateApiKeys is not only called by the canister controller (in prod the principal managing the API keys is different than the controller)

Good catch! I've updated it so that the Setup::update_api_keys method uses the default caller, but there is a new method where one can specify the caller (currently only used in mock_api_keys to use the controller).

nit: I would only keep one method update_api_keys, but add the caller as an argument as in update_api_keys_with_caller so that there is only one method for that endpoint and tests are forced to use it. Currently when looking at the tests it's a bit unclear that the same principal is used in manage_api_keys and o call update_api_keys.

tests/tests.rs

lpahlavi

Thanks a lot for the review @gregorydemay! I believe this should be ready for another round 🚀

tests/mock_http_runtime/mod.rs

tests/setup/mod.rs

lpahlavi · 2025-09-15T12:43:59Z

tests/setup/mod.rs

+            self.canister_id,
+        )
    }



Good catch! I've updated it so that the Setup::update_api_keys method uses the default caller, but there is a new method where one can specify the caller (currently only used in mock_api_keys to use the controller).

gregorydemay · 2025-09-15T14:08:37Z

tests/setup/mod.rs

+            self.canister_id,
+        )
    }



nit: I would only keep one method update_api_keys, but add the caller as an argument as in update_api_keys_with_caller so that there is only one method for that endpoint and tests are forced to use it. Currently when looking at the tests it's a bit unclear that the same principal is used in manage_api_keys and o call update_api_keys.

## 🤖 New release * `evm_rpc_types`: 2.1.0 -> 3.0.0 (✓ API compatible changes) * `evm_rpc_client`: 0.1.0 * `evm_rpc`: 2.5.0 -> 2.6.0 (✓ API compatible changes) <details><summary>Changelog</summary> ## `evm_rpc_types` <blockquote> ## [3.0.0] - 2025-10-20 ### Added - Add conversions between several types in this crate and the corresponding `alloy` types. These conversions are only available with the `alloy` feature ([#465](#465), [#466](#466), [#467](#467), [#476](#476)). - **Breaking:** Add `root` and `cumulativeGasUsed` fields to `TransactionsReceipt` type ([#474](#474)) [3.0.0]: https://github.com/dfinity/evm-rpc-canister/compare/evm_rpc_types-v2.1.0..evm_rpc_types-v3.0.0 </blockquote> ## `evm_rpc_client` <blockquote> ## [0.1.0] - 2025-10-20 ### Added - Add methods to modify RPC config to `RequestBuilder` ([#494](#494)) - Add `alloy` feature flag to `evm_rpc_client` ([#484](#484)) - Add new `json_request` endpoint ([#477](#477)) - Add client support for `eth_getTransactionReceipt` ([#476](#476)) - Add `eth_sendRawTransaction` client support ([#467](#467)) - Add client support for `eth_call` ([#466](#466)) - Add client support for `eth_getTransactionCount` ([#465](#465)) - Add support for `eth_feeHistory` to client ([#460](#460)) - Add support for `eth_getBlockByNumber` to client ([#459](#459)) - Add EVM RPC canister client ([#447](#447)) [0.1.0]: https://github.com/dfinity/evm-rpc-canister/releases/tag/evm_rpc_client-v0.1.0 </blockquote> ## `evm_rpc` <blockquote> ## [2.6.0] - 2025-10-20 ### Added - Add support for `root` and `cumulativeGasUsed` fields in `eth_getTransactionReceipt` response ([#474](#474)) - Add new `json_request` endpoint and deprecate existing `request` endpoint ([#477](#477)) ### Changed - Update `ic-cdk` to `v0.18.7` ([#489](#489)) - Update `dfx` to `v0.29.0` ([#490](#490)) - Cleanup unused dependencies ([#491](#491)) ### Removed - **Breaking**: Remove `getMetrics` endpoint, this is acceptable since it was a debugging endpoint ([#479](#479)) ### Fixed - Add `err_max_response_size_exceeded` to Prometheus metrics ([#487](#487)) [2.6.0]: v2.5.0...v2.6.0 </blockquote> </details> --- This PR was generated with [release-plz](https://github.com/release-plz/release-plz/). --------- Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com> Co-authored-by: Louis Pahlavi <louis.pahlavi@dfinity.org>

## 🤖 New release * `evm_rpc_types`: 2.1.0 -> 3.0.0 (✓ API compatible changes) * `evm_rpc_client`: 0.1.0 * `evm_rpc`: 2.5.0 -> 2.6.0 (✓ API compatible changes) <details><summary>Changelog</summary> ## `evm_rpc_types` <blockquote> ## [3.0.0] - 2025-10-20 ### Added - Add conversions between several types in this crate and the corresponding `alloy` types. These conversions are only available with the `alloy` feature ([#465](dfinity/evm-rpc-canister#465), [#466](dfinity/evm-rpc-canister#466), [#467](dfinity/evm-rpc-canister#467), [#476](dfinity/evm-rpc-canister#476)). - **Breaking:** Add `root` and `cumulativeGasUsed` fields to `TransactionsReceipt` type ([#474](dfinity/evm-rpc-canister#474)) [3.0.0]: https://github.com/dfinity/evm-rpc-canister/compare/evm_rpc_types-v2.1.0..evm_rpc_types-v3.0.0 </blockquote> ## `evm_rpc_client` <blockquote> ## [0.1.0] - 2025-10-20 ### Added - Add methods to modify RPC config to `RequestBuilder` ([#494](dfinity/evm-rpc-canister#494)) - Add `alloy` feature flag to `evm_rpc_client` ([#484](dfinity/evm-rpc-canister#484)) - Add new `json_request` endpoint ([#477](dfinity/evm-rpc-canister#477)) - Add client support for `eth_getTransactionReceipt` ([#476](dfinity/evm-rpc-canister#476)) - Add `eth_sendRawTransaction` client support ([#467](dfinity/evm-rpc-canister#467)) - Add client support for `eth_call` ([#466](dfinity/evm-rpc-canister#466)) - Add client support for `eth_getTransactionCount` ([#465](dfinity/evm-rpc-canister#465)) - Add support for `eth_feeHistory` to client ([#460](dfinity/evm-rpc-canister#460)) - Add support for `eth_getBlockByNumber` to client ([#459](dfinity/evm-rpc-canister#459)) - Add EVM RPC canister client ([#447](dfinity/evm-rpc-canister#447)) [0.1.0]: https://github.com/dfinity/evm-rpc-canister/releases/tag/evm_rpc_client-v0.1.0 </blockquote> ## `evm_rpc` <blockquote> ## [2.6.0] - 2025-10-20 ### Added - Add support for `root` and `cumulativeGasUsed` fields in `eth_getTransactionReceipt` response ([#474](dfinity/evm-rpc-canister#474)) - Add new `json_request` endpoint and deprecate existing `request` endpoint ([#477](dfinity/evm-rpc-canister#477)) ### Changed - Update `ic-cdk` to `v0.18.7` ([#489](dfinity/evm-rpc-canister#489)) - Update `dfx` to `v0.29.0` ([#490](dfinity/evm-rpc-canister#490)) - Cleanup unused dependencies ([#491](dfinity/evm-rpc-canister#491)) ### Removed - **Breaking**: Remove `getMetrics` endpoint, this is acceptable since it was a debugging endpoint ([#479](dfinity/evm-rpc-canister#479)) ### Fixed - Add `err_max_response_size_exceeded` to Prometheus metrics ([#487](dfinity/evm-rpc-canister#487)) [2.6.0]: dfinity/evm-rpc-canister@v2.5.0...v2.6.0 </blockquote> </details> --- This PR was generated with [release-plz](https://github.com/release-plz/release-plz/). --------- Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com> Co-authored-by: Louis Pahlavi <louis.pahlavi@dfinity.org>

lpahlavi changed the base branch from main to lpahlavi/XC-412-eth-fee-history September 8, 2025 15:05

lpahlavi requested a review from gregorydemay September 9, 2025 12:11

lpahlavi marked this pull request as ready for review September 9, 2025 12:11

lpahlavi requested a review from a team as a code owner September 9, 2025 12:11

Base automatically changed from lpahlavi/XC-412-eth-fee-history to main September 11, 2025 09:58

lpahlavi force-pushed the lpahlavi/XC-412-eth-get-transaction-count branch from 431e0ed to 61d8973 Compare September 11, 2025 09:59

lpahlavi added 7 commits September 11, 2025 12:01

XC-412: Add support for eth_getTransactionCount

84a0745

XC-412: Formatting

aaccc36

XC-412: Integration tests

6904c85

XC-412: Integration tests part 2

5107d08

XC-412: Add call_query method

f51740e

XC-412: Fix imports in doc

c9b30f3

XC-412: Add missing .await

f1a3bdb

lpahlavi force-pushed the lpahlavi/XC-412-eth-get-transaction-count branch from 61d8973 to f1a3bdb Compare September 11, 2025 10:01

gregorydemay reviewed Sep 15, 2025

View reviewed changes

lpahlavi added 4 commits September 15, 2025 12:00

XC-412: Revert JSON debugging for mock body

8c924a0

XC-412: Try fewer times to upgrade canister

f99440d

XC-412: Call getMetrics and http_request with anonymous caller

00a8527

XC-412: Default to update API keys with default caller

859bca8

lpahlavi commented Sep 15, 2025

View reviewed changes

lpahlavi requested a review from gregorydemay September 15, 2025 12:56

gregorydemay approved these changes Sep 15, 2025

View reviewed changes

XC-412: Inline update_api_keys

414c727

lpahlavi merged commit 6c04638 into main Sep 15, 2025
11 checks passed

lpahlavi deleted the lpahlavi/XC-412-eth-get-transaction-count branch September 15, 2025 14:45

github-actions bot mentioned this pull request Sep 24, 2025

chore: release #483

Closed

This was referenced Oct 20, 2025

chore: release #499

Closed

chore: release #500

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

feat: add client support for `eth_getTransactionCount`#465

feat: add client support for `eth_getTransactionCount`#465
lpahlavi merged 12 commits intomainfrom
lpahlavi/XC-412-eth-get-transaction-count

lpahlavi commented Sep 8, 2025

Uh oh!

gregorydemay left a comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

gregorydemay Sep 15, 2025

Uh oh!

lpahlavi Sep 15, 2025

Uh oh!

gregorydemay Sep 15, 2025

Uh oh!

Uh oh!

lpahlavi left a comment

Uh oh!

Uh oh!

Uh oh!

lpahlavi Sep 15, 2025

Uh oh!

gregorydemay Sep 15, 2025

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

Conversation

lpahlavi commented Sep 8, 2025

Uh oh!

gregorydemay left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

gregorydemay Sep 15, 2025

Choose a reason for hiding this comment

Uh oh!

lpahlavi Sep 15, 2025

Choose a reason for hiding this comment

Uh oh!

gregorydemay Sep 15, 2025

Choose a reason for hiding this comment

Uh oh!

Uh oh!

lpahlavi left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

lpahlavi Sep 15, 2025

Choose a reason for hiding this comment

Uh oh!

gregorydemay Sep 15, 2025

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants