Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: max_response_bytes is 2MB not 2MiB #554

Closed
wants to merge 2 commits into from

Conversation

ninegua
Copy link
Member

@ninegua ninegua commented Feb 4, 2025

Description

The documentation (and example) for max_response_bytes is wrong. According to the interface spec and IC's implementation, the limit is 2MB, not 2MiB.

Checklist:

  • The title of this PR complies with Conventional Commits.
  • I have edited the CHANGELOG accordingly.
  • I have made corresponding changes to the documentation.

@lwshang
Copy link
Contributor

lwshang commented Feb 4, 2025

Thanks for catching this documentation issue regarding max_response_bytes!
The main branch is currently frozen, with active development happening on next. We plan to merge next into main after the "Best-Effort Responses" feature launches on mainnet. I'll make sure the documentation and example correctly specify 2MB (not 2MiB) on the next branch.

@lwshang lwshang closed this Feb 4, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants