feat!: next generation of Rust CDK #521
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Add RejectionCode variant SysUnknown * refactor: Call struct * encode_args once * update ic0 with new system API * with_best_effort_response() * doc comments * safe wrapper for msg_deadline() * refactor * add e2e * state machine script using git tag * basic test pass * configs after setting args * call_and_forget * minor improvements * use recent beta dfx which has new system API * clippy * load.bash * update candid-extractor * fmt * group methods in traits * default to 10s timeout:wq * prelude mod * fmt
* ic0: handle 32/64-bits system API * adjust safe bindings * update safety notes * Update call.rs Co-authored-by: Adam Spofford <[email protected]> --------- Co-authored-by: Adam Spofford <[email protected]>
| } | ||
|
|
||
| /// Sends the call and decodes the reply to a Candid type with a decoding quota. | ||
| fn call_with_decoder_config<R: for<'b> ArgumentDecoder<'b>>( |
There was a problem hiding this comment.
With best-effort call, we can merge this function with the original call function. If the call is best-effort, put a decoding quota, if it's not, decode without the quota.
There was a problem hiding this comment.
The "decoding quota" and "best effort response" are orthogonal concepts. And they affect different stages of the inter-canister call. So I insist on keeping them separate.
* Add ic-cdk-management-canister crate * move management canister code * flat hierarchy and exclude candid-extractor * exclude root Cargo.lock * rm docs * update workflows * fmt * fix doc * cleanup examples.yml * rm candid-extractor * fix examples.yml * fix cont. * refactor e2e-tests 1:1 mapping of canisters to tests * remove examples
…same name as the function itself (#525) * add a test case to reveal the bug * fix: update/query macro could not handle function arguments with the same name as the function itself * changelog
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
SDK-1853
Description
This PR collects a few big changes:
How Has This Been Tested?
Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration.
Checklist: