Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor!: crates architecture #522

Merged
merged 14 commits into from
Oct 9, 2024
Merged

refactor!: crates architecture #522

merged 14 commits into from
Oct 9, 2024

Conversation

lwshang
Copy link
Contributor

@lwshang lwshang commented Oct 8, 2024

SDK-1854

Description

A new ic-cdk-management-canister crate is added which contains the code used to be in ic_cdk::api::management_canister.

The src/ folder is removed. And ic* crates are in the root.

examples/ and the examples.yml workflow are removed. The test coverage they provided will be implemented in the e2e-tests framework which will be in another PR.

docs/ are removed since they are outdated and not included in the document site anymore.

e2e-tests/ got some cleanup. Each canister has a corresponding test file with the same name.

@lwshang lwshang changed the title chore: separate ic-cdk-management-canister refactor!: crates architecture Oct 9, 2024
@lwshang lwshang marked this pull request as ready for review October 9, 2024 23:40
@lwshang lwshang requested a review from a team as a code owner October 9, 2024 23:40
@lwshang lwshang merged commit 7a64c21 into next Oct 9, 2024
10 checks passed
@lwshang lwshang deleted the lwshang/SDK-1854 branch October 9, 2024 23:40
@lwshang lwshang mentioned this pull request Oct 11, 2024
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant