Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve the workspace #179

Closed
wants to merge 3 commits into from
Closed

Improve the workspace #179

Show file tree
Hide file tree
Changes from 2 commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
0ee10dd
Improve the workspace
rianby64 Dec 10, 2018
0c67538
Merge branch 'master' into master
snuggs Dec 11, 2018
19d7b17
Merge branch 'master' into master
snuggs Dec 13, 2018
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 6 additions & 0 deletions .vscode/settings.json
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,6 @@
{
// Configure file associations to languages (e.g. `"*.extension": "html"`). These have precedence over the default associations of the languages installed.
"files.associations": {
"*.es": "javascript"
}
}
27 changes: 27 additions & 0 deletions configure/README.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,3 +5,30 @@ Scripts used for configuring server nodes
## `nginx`

nginx setup. Derived from [`whatwg/misc-server`](https://github.com/whatwg/misc-server)

## `vscode`
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

is this section necessary to add in addition to the config file?

if so, does it really belong in the main README or could it go into a separate doc page?

Copy link
Member

@snuggs snuggs Dec 11, 2018 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hmmm @brandondees @rianby64 you both are right. It IS part of "configuration" per say. The thought was anything "configure" related stuff goes in /configure. But that is more internal dev related (perhaps shouldn't be?). Really was just a place I could quarantine the "This is how you get nginx to work for WHATWG" code I got from WHATWG/meta when we did nginx.

IMHO this documentation should be as close to introduction as possible. Perhaps an IDE section in main README.md? /cc @tmornini

In addendum i'll add what I did for VIM.

Thanks for this @rianby64


1. CTRL+SHIFT+P, search for "preferences open settings (JSON)"
2. Open the "Workspace settings" tab
3. Add the property "files.assiciations" if not present or extend it with the value "*.es": "javascript"

Should looks like

```javascript
"files.associations": {
"*.es": "javascript"
}
```
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

EASY PEASY @rianby64. This is great. Now where it should go see above. But wherever it goes this is great.


or if your workspace settings is empty then, put the following

```javascript
{
// Configure file associations to languages (e.g. `"*.extension": "html"`). These have precedence over the default associations of the languages installed.
"files.associations": {
"*.es": "javascript"
}
}
```

The result of the steps above are in the file `.vscode/settings.json`.
1 change: 0 additions & 1 deletion package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -56,7 +56,6 @@
"postcss-cli": "*",
"autoprefixer": "*",
"browser-sync": "*",
"devtools-terminal": "*",
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@rianby64 Also have updated some dependencies due to security risk. Check for merging of #181 which may cause (easy) conflict that may need fixing. But DEFINITELY want to get rid of this.

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Bad news. If you rely on "devtools-terminal" then please, check the following:
https://github.com/chjj/pty.js#todo

Add a way of determining the current foreground job for platforms other than Linux and OSX/Darwin.

devtools-terminal relies on pty which works only on Mac.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@rianby64 EXACTLY. Let's kill it with fire. To be honest it only was around when I was testing VIM in browser. I'm going to go ahead and merge this.

"postcss-custom-properties": "*"
},
"dependencies": {
Expand Down