Improve the workspace #179
Conversation
- Remove an unnecessary dependency: "devtools-terminal". - Add the support for .es extensions to VSCode
| @@ -5,3 +5,30 @@ Scripts used for configuring server nodes | |||
| ## `nginx` | |||
|
|
|||
| nginx setup. Derived from [`whatwg/misc-server`](https://github.com/whatwg/misc-server) | |||
|
|
|||
| ## `vscode` | |||
There was a problem hiding this comment.
is this section necessary to add in addition to the config file?
if so, does it really belong in the main README or could it go into a separate doc page?
There was a problem hiding this comment.
Hmmm @brandondees @rianby64 you both are right. It IS part of "configuration" per say. The thought was anything "configure" related stuff goes in /configure. But that is more internal dev related (perhaps shouldn't be?). Really was just a place I could quarantine the "This is how you get nginx to work for WHATWG" code I got from WHATWG/meta when we did nginx.
IMHO this documentation should be as close to introduction as possible. Perhaps an IDE section in main README.md? /cc @tmornini
In addendum i'll add what I did for VIM.
Thanks for this @rianby64
package.json
Outdated
| @@ -36,7 +36,7 @@ | |||
| }, | |||
| "scripts": { | |||
| "test": "bin/test", | |||
| "start": "bin/serve", | |||
| "start": "bin/browse", | |||
There was a problem hiding this comment.
I think we should leave this as serve as Heroku would blowup with browser sync.
| @@ -57,7 +57,6 @@ | |||
| "postcss-cli": "*", | |||
| "autoprefixer": "*", | |||
| "browser-sync": "*", | |||
| "devtools-terminal": "*", | |||
There was a problem hiding this comment.
Bad news. If you rely on "devtools-terminal" then please, check the following:
https://github.com/chjj/pty.js#todo
Add a way of determining the current foreground job for platforms other than Linux and OSX/Darwin.
devtools-terminal relies on pty which works only on Mac.
There was a problem hiding this comment.
@rianby64 EXACTLY. Let's kill it with fire. To be honest it only was around when I was testing VIM in browser. I'm going to go ahead and merge this.
| "files.associations": { | ||
| "*.es": "javascript" | ||
| } | ||
| ``` |
There was a problem hiding this comment.
EASY PEASY @rianby64. This is great. Now where it should go see above. But wherever it goes this is great.
package.json
Outdated
| "start": "bin/browse", | ||
| "package": "bin/package", | ||
| "postinstall": "bin/publish" | ||
| "test": "bin/snuggsi test", |
There was a problem hiding this comment.
@brandondees @rianby64 @tmornini wow can resolve merge conflicts from Github now. :-)
@rianby64 took care of it and merged into your branch as it was my doing from merging #175 earlier today.
|
@rianby64 yeah man we gotta get rid of devtools. |
|
@brandondees @rianby64 peep game... >>> microsoft/vscode#62976 |
Motivation and Context
devtools-terminal is not compatible with linux environments. If run
npm installthen a bunch of errors will appear and this fact obstructs the development in other platforms different to MacOS.How Has This Been Tested?
After removing that dependency, I ran all the scripts and all of them didn't fail. Looks like that dependecy can be safely dropped.