-
Notifications
You must be signed in to change notification settings - Fork 2.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
new icon: Eleventy (original, plain) #413
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hello @tylensthilaire and thanks for your contribution!
When I take a look at the 11ty repo and website I always see the logo not squared (like in your contribution) but instead in a cuboid form:
Are you able to provide any official logo sources?
You're right. It's only squared off on their Twitter and favicon, likely because of the constraints of those formats. Will update. |
I will wait for @Thomas-Boi to resolve #414 so we can have a look at the font version. |
Hi @tylensthilaire , Unfortunately, we are running into some issues checking your SVGs. It seems that your forked repo is from an older version of our You might find this link useful to update your repo. Cheers, |
Pull latest commit from upstream Develop
Pulled in the latest from develop. Must have PRed into Develop instead of Master by mistake. |
Hi @tylensthilaire , Thank you for your patient. It seems that we ran into an unexpected issue in our peek script. As you might know, our repo use icomoon to create our icons. Since this is a website, our script might run into issue selecting items whenever the site is updated. It seems to be what's happening here since there are similarity between this PR and #415. In summary, the Icomoon app now show/not show certain elements depends on the color of the SVG that you upload. For more details, you can see my comment. We will publish a fix and merge as soon as possible. When that happens, would you be ok with updating your repo one more time with this fix? We really appreciate your patient so far and we hope to see your icons in our repo soon. Cheers, |
Hi @tylensthilaire , We have merged our fix for the issue that we are seeing into develop. Can you please merge this fix into your repo please? If this doesn't fix the issue, I will personally check your icon myself 👍 |
new icon: Eleventy (original, plain)
Original and plain icons for Eleventy
Jpeg logo for reference: