Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

new icon: Eleventy (original, plain) #413

Merged
merged 6 commits into from
Jan 5, 2021

Conversation

tylensthilaire
Copy link
Contributor

Original and plain icons for Eleventy

Jpeg logo for reference:
8ZfcJCXi_400x400

@amacado amacado changed the base branch from master to develop December 30, 2020 12:53
@amacado amacado added the feature:icon Use this label for pull requests when a new icon is ready to be added to the collection label Dec 30, 2020
Copy link
Member

@amacado amacado left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hello @tylensthilaire and thanks for your contribution!

When I take a look at the 11ty repo and website I always see the logo not squared (like in your contribution) but instead in a cuboid form:
image

Are you able to provide any official logo sources?

@amacado amacado added the bot:peek Use this label to trigger peek-bot. Remove and re-add the label to re-trigger label Dec 30, 2020
@tylensthilaire
Copy link
Contributor Author

You're right. It's only squared off on their Twitter and favicon, likely because of the constraints of those formats.

Will update.

@amacado
Copy link
Member

amacado commented Dec 30, 2020

I will wait for @Thomas-Boi to resolve #414 so we can have a look at the font version.

@amacado amacado added bot:peek Use this label to trigger peek-bot. Remove and re-add the label to re-trigger and removed bot:peek Use this label to trigger peek-bot. Remove and re-add the label to re-trigger labels Dec 30, 2020
@Thomas-Boi
Copy link
Member

Hi @tylensthilaire ,

Unfortunately, we are running into some issues checking your SVGs. It seems that your forked repo is from an older version of our master branch. In order for us to check your icons, please pull our latest commit from our develop to your fork.

You might find this link useful to update your repo.

Cheers,
Thomas

Pull latest commit from upstream Develop
@tylensthilaire
Copy link
Contributor Author

tylensthilaire commented Dec 31, 2020

Pulled in the latest from develop. Must have PRed into Develop instead of Master by mistake.

@amacado amacado added bot:peek Use this label to trigger peek-bot. Remove and re-add the label to re-trigger and removed bot:peek Use this label to trigger peek-bot. Remove and re-add the label to re-trigger labels Dec 31, 2020
@Thomas-Boi
Copy link
Member

Hi @tylensthilaire ,

Thank you for your patient. It seems that we ran into an unexpected issue in our peek script. As you might know, our repo use icomoon to create our icons. Since this is a website, our script might run into issue selecting items whenever the site is updated. It seems to be what's happening here since there are similarity between this PR and #415.

In summary, the Icomoon app now show/not show certain elements depends on the color of the SVG that you upload. For more details, you can see my comment.

We will publish a fix and merge as soon as possible. When that happens, would you be ok with updating your repo one more time with this fix? We really appreciate your patient so far and we hope to see your icons in our repo soon.

Cheers,
Thomas

@Thomas-Boi
Copy link
Member

Hi @tylensthilaire ,

We have merged our fix for the issue that we are seeing into develop. Can you please merge this fix into your repo please? If this doesn't fix the issue, I will personally check your icon myself 👍

@Thomas-Boi Thomas-Boi added bot:peek Use this label to trigger peek-bot. Remove and re-add the label to re-trigger and removed bot:peek Use this label to trigger peek-bot. Remove and re-add the label to re-trigger labels Jan 5, 2021
@Thomas-Boi
Copy link
Member

Hello,

Here is the icon version of your svg:
new_icons
screenshot_0

Everything looks good so we'll be merging your PR into the repo. Thank you very much for your work and patient while waiting for the issues to be fixed 😃

Happy New Year,

@Thomas-Boi Thomas-Boi merged commit 984530b into devicons:develop Jan 5, 2021
@tylensthilaire tylensthilaire deleted the master branch January 5, 2021 09:34
@amacado amacado mentioned this pull request Jan 19, 2021
GCHQDeveloper926 pushed a commit to GCHQDeveloper926/devicon that referenced this pull request Dec 20, 2024
new icon: Eleventy (original, plain)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bot:peek Use this label to trigger peek-bot. Remove and re-add the label to re-trigger feature:icon Use this label for pull requests when a new icon is ready to be added to the collection
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants