bot:peek failing "UnhandledPromiseRejectionWarning: Error: Request failed with status code 403"

[amacado]

As you can see in PR #413 the bot:peek action is failing which can be traced to

Is this error caused by not using the latest version of devicons/public-upload-to-imgur? @Thomas-Boi

[Thomas-Boi]

Yes it is. I'll work on the peek bot pr and commit your suggestions so we can merge it asap.

[Thomas-Boi]

Hi @amacado ,

I've added the some new features to the peek bot pr. The main feature is error handling for when an error is found, such as when the name can't be find in the title.

You can see an example in this PR at the very bottom. If you check the corresponding action, you can see that the script failed when it can't find the title.

[amacado]

Still failing.. see https://github.com/devicons/devicon/actions/runs/453414999

[Thomas-Boi]

I think this is because the source branch didn't get the new commits yet. In fact, it seems like their source branch is forked from an older master:

The only solution is to ask them to pull our develop into their master.

[amacado]

Even with updated branch it fails (but a new error) 🤣
https://github.com/devicons/devicon/runs/1630175599

[Thomas-Boi]

Hmm, this is interesting. I'll take another look at the script.

[Thomas-Boi]

@amacado please see my notes at the bottom of #421

[amacado]

@Thomas-Boi I have good and bad news. I found the reason why the bot:peek command is still failing. It's because of the restrictions of Github Secrets:

Secrets are not passed to workflows that are triggered by a pull request from a fork
https://docs.github.com/en/free-pro-team@latest/actions/reference/encrypted-secrets

That's the reason why PR which are initiated from this repository working well but when the action is executed from a forked pull request it will fail on the image upload step with error code 403. Since the CLIENT_ID is stored as secret and is required when the upload is beeing executed it fails and following execution steps fill fail accordingly.

I could not find a easy solution for this problem, maybe we can use the build artifacts or the GitHub CDN as alternative to imgur. Or we need to find a different hosting provider without the need of a secret (I wasn't able to find one).

[Thomas-Boi]

Hey amacado,

You are correct. I'm surprised that I didn't notice this while making the workflow. Seems like we will be going back to the upload-artifacts then. Oh well😞

I will change the workflow file so we use the old method. As for the GitHub CDN, that was my first go to method but it seems like it's currently only available using their website (kinda like Icomoon). Maybe using Selenium might help but that can't be done right now.

[Thomas-Boi]

Closing this issue since the fix is in develop