Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Finish Desktop apps #69

Merged
merged 54 commits into from
Dec 30, 2018
Merged

Finish Desktop apps #69

merged 54 commits into from
Dec 30, 2018

Commits on Dec 24, 2018

  1. [Desktop] Setup Electron + CRA from web project (without code duplica… 

    …tion)
    @brunolemos
    brunolemos committed Dec 24, 2018
    Configuration menu
    Copy the full SHA
    7a2ce56 View commit details
    Browse the repository at this point in the history

  2. When app is on menubar mode, hide icon from dock

    @amorist @brunolemos
    amorist authored and brunolemos committed Dec 24, 2018
    Configuration menu
    Copy the full SHA
    87b1646 View commit details
    Browse the repository at this point in the history

  3. [Desktop] Auto reload Electron on change

    @brunolemos
    brunolemos committed Dec 24, 2018
    Configuration menu
    Copy the full SHA
    dc5dd84 View commit details
    Browse the repository at this point in the history

  4. [Desktop] Change arrow color based on current theme

    @brunolemos
    brunolemos committed Dec 24, 2018
    Configuration menu
    Copy the full SHA
    5bc863e View commit details
    Browse the repository at this point in the history

Commits on Dec 25, 2018

  1. [Desktop] Rename electron.ts to index.ts

    @brunolemos
    brunolemos committed Dec 25, 2018
    Configuration menu
    Copy the full SHA
    62727b3 View commit details
    Browse the repository at this point in the history

  2. [Desktop] Fix icons 

    Also regenerated icons for all platforms, now with a gradient and better aligment
    @brunolemos
    brunolemos committed Dec 25, 2018
    Configuration menu
    Copy the full SHA
    81b7b93 View commit details
    Browse the repository at this point in the history

  3. [Desktop] Run OAuth flow on user's browser using deep linking

    @brunolemos
    brunolemos committed Dec 25, 2018
    Configuration menu
    Copy the full SHA
    5a611e3 View commit details
    Browse the repository at this point in the history

Commits on Dec 27, 2018

  1. [Desktop] Rewrote how Desktop/Menubar modes are handled 

    Desktop mode is now the default one

Desktop mode starts maximized

Desktop mode is now frameless

Create only one window, reuse between Desktop and Menubar

Fix Menu and, by consequence, fix Copy, Paste, Select All, etc

Remove empty button from TouchBar

Option to make window be always at the center

Handle Full Screen Mode

Allow showing DevTools on development only

Show options on Dock icon, Menu and Tray icon

Add menu items to open DevHub on GitHub, Report bug and Send feedback

Fix app not reopening after Cmd+W

Remove arrow
    @brunolemos
    brunolemos committed Dec 27, 2018
    Configuration menu
    Copy the full SHA
    dfd27bc View commit details
    Browse the repository at this point in the history

Commits on Dec 28, 2018

  1. [Desktop][Windows] Fix undefined app.dock

    @brunolemos
    brunolemos committed Dec 28, 2018
    Configuration menu
    Copy the full SHA
    f2a8274 View commit details
    Browse the repository at this point in the history

  2. [Desktop] Use electron-is-dev instead of NODE_ENV 

    Fix problem on Windows without bash shell
    @brunolemos
    brunolemos committed Dec 28, 2018
    Configuration menu
    Copy the full SHA
    2785c78 View commit details
    Browse the repository at this point in the history

  3. [Windows] Fix pushd

    @brunolemos
    brunolemos committed Dec 28, 2018
    Configuration menu
    Copy the full SHA
    212d448 View commit details
    Browse the repository at this point in the history

  4. [Windows] Use cross-env to set env vars

    @brunolemos
    brunolemos committed Dec 28, 2018
    Configuration menu
    Copy the full SHA
    a4ac694 View commit details
    Browse the repository at this point in the history

  5. [Desktop] Only create frameless window on macOS

    @brunolemos
    brunolemos committed Dec 28, 2018
    Configuration menu
    Copy the full SHA
    a9eddbf View commit details
    Browse the repository at this point in the history

  6. [Desktop] Only enable Menubar Mode on macOS

    @brunolemos
    brunolemos committed Dec 28, 2018
    Configuration menu
    Copy the full SHA
    2d2a5d9 View commit details
    Browse the repository at this point in the history

  7. [Desktop][Windows] Fix window max dimensions

    @brunolemos
    brunolemos committed Dec 28, 2018
    Configuration menu
    Copy the full SHA
    8105f5f View commit details
    Browse the repository at this point in the history

  8. Merge branch 'desktop' of github.com:devhubapp/devhub into desktop

    @brunolemos
    brunolemos committed Dec 28, 2018
    Configuration menu
    Copy the full SHA
    ab3cc38 View commit details
    Browse the repository at this point in the history

  9. [Desktop] Move mode switch from View menu to a new Options menu

    @brunolemos
    brunolemos committed Dec 28, 2018
    Configuration menu
    Copy the full SHA
    7c28376 View commit details
    Browse the repository at this point in the history

  10. [Desktop][Windows] Remove Bring All to Front menu

    @brunolemos
    brunolemos committed Dec 28, 2018
    Configuration menu
    Copy the full SHA
    9466501 View commit details
    Browse the repository at this point in the history

  11. Change title to only DevHub

    @brunolemos
    brunolemos committed Dec 28, 2018
    Configuration menu
    Copy the full SHA
    0c31d6a View commit details
    Browse the repository at this point in the history

  12. Revert "[Desktop] Move mode switch from View menu to a new Options menu" 

    This reverts commit 7c28376.
    @brunolemos
    brunolemos committed Dec 28, 2018
    Configuration menu
    Copy the full SHA
    3a34096 View commit details
    Browse the repository at this point in the history

  13. [Desktop] Enable lockOnCenter by default only on macOS

    @brunolemos
    brunolemos committed Dec 28, 2018
    Configuration menu
    Copy the full SHA
    cc51488 View commit details
    Browse the repository at this point in the history

  14. [Desktop][Windows] Fix Menubar mode + Handle all possible taskbar pos… 

    …itions
    @brunolemos
    brunolemos committed Dec 28, 2018
    Configuration menu
    Copy the full SHA
    439fb3d View commit details
    Browse the repository at this point in the history

  15. [Desktop][macOS] Small fix on tray click handler

    @brunolemos
    brunolemos committed Dec 28, 2018
    Configuration menu
    Copy the full SHA
    f0a788d View commit details
    Browse the repository at this point in the history

  16. [Desktop][Windows] Hide window on blur on Menubar mode

    @brunolemos
    brunolemos committed Dec 28, 2018
    Configuration menu
    Copy the full SHA
    f2ca73f View commit details
    Browse the repository at this point in the history

  17. Merge branch 'master' of github.com:devhubapp/devhub into desktop

    @brunolemos
    brunolemos committed Dec 28, 2018
    Configuration menu
    Copy the full SHA
    ce79fce View commit details
    Browse the repository at this point in the history

Commits on Dec 29, 2018

  1. Use shx instead of rimraf to support more commands

    @brunolemos
    brunolemos committed Dec 29, 2018
    Configuration menu
    Copy the full SHA
    81404e1 View commit details
    Browse the repository at this point in the history

  2. [Desktop] Fix node_modules not being included

    @brunolemos
    brunolemos committed Dec 29, 2018
    Configuration menu
    Copy the full SHA
    688e636 View commit details
    Browse the repository at this point in the history

  3. [Desktop] Disable lockOnCenter by default 

    On all platforms
    @brunolemos
    brunolemos committed Dec 29, 2018
    Configuration menu
    Copy the full SHA
    814e7cc View commit details
    Browse the repository at this point in the history

  4. [Desktop] Persist window size, position and user preferences 

    Including Desktop/Menubar mode and lockOnCenter option
    @brunolemos
    brunolemos committed Dec 29, 2018
    Configuration menu
    Copy the full SHA
    dd6dd92 View commit details
    Browse the repository at this point in the history

  5. [Desktop] Move some code to a init function

    @brunolemos
    brunolemos committed Dec 29, 2018
    Configuration menu
    Copy the full SHA
    1c2c103 View commit details
    Browse the repository at this point in the history

  6. [Desktop] Prevent multiple instances of the app 

    Fix devhub:// on Windows that was opening a new instance instead of focusing on current instance
    @brunolemos
    brunolemos committed Dec 29, 2018
    Configuration menu
    Copy the full SHA
    e5ff519 View commit details
    Browse the repository at this point in the history

  7. [Desktop][Windows] Fix oauth flow 

    Fix deep linking by getting url from second-instance argv and dispatching an open-url event that is being listened by the Linking API
    @brunolemos
    brunolemos committed Dec 29, 2018
    Configuration menu
    Copy the full SHA
    4c5c0f8 View commit details
    Browse the repository at this point in the history

  8. [Desktop] Maximize window on first launch

    @brunolemos
    brunolemos committed Dec 29, 2018
    Configuration menu
    Copy the full SHA
    739746d View commit details
    Browse the repository at this point in the history

  9. [Desktop][Windows] Fix window losing maximized state on tray click

    @brunolemos
    brunolemos committed Dec 29, 2018
    Configuration menu
    Copy the full SHA
    b9758dd View commit details
    Browse the repository at this point in the history

  10. [Desktop] Enable Linux target

    @brunolemos
    brunolemos committed Dec 29, 2018
    Configuration menu
    Copy the full SHA
    856c101 View commit details
    Browse the repository at this point in the history

  11. [Desktop] Disable nodeIntegration as a security precaution 

    electron/electron#5113

electron/electron#4362

PaulLeCam/react-native-electron#6
    @brunolemos
    brunolemos committed Dec 29, 2018
    Configuration menu
    Copy the full SHA
    d2b21cb View commit details
    Browse the repository at this point in the history

  12. [Desktop] Trying to fix logo not showing on release build after login 

    Didnt work
    @brunolemos
    brunolemos committed Dec 29, 2018
    Configuration menu
    Copy the full SHA
    aa15927 View commit details
    Browse the repository at this point in the history

  13. [Desktop] Setup React and Redux devtools extensions

    @brunolemos
    brunolemos committed Dec 29, 2018
    Configuration menu
    Copy the full SHA
    1d5e625 View commit details
    Browse the repository at this point in the history

  14. [Desktop] Explicitly disable contextIsolation 

    Required for the window.ipc to work on oauth flow
    @brunolemos
    brunolemos committed Dec 29, 2018
    Configuration menu
    Copy the full SHA
    d7a95c8 View commit details
    Browse the repository at this point in the history

  15. [Security] Disable window.eval 

    As recommended by Electron warning
    @brunolemos
    brunolemos committed Dec 29, 2018
    Configuration menu
    Copy the full SHA
    9a0d007 View commit details
    Browse the repository at this point in the history

  16. [Desktop] Fix broken logo after login

    @brunolemos
    brunolemos committed Dec 29, 2018
    Configuration menu
    Copy the full SHA
    3896e8d View commit details
    Browse the repository at this point in the history

  17. [Desktop] Fix broken Reload after login

    @brunolemos
    brunolemos committed Dec 29, 2018
    Configuration menu
    Copy the full SHA
    aa9dd12 View commit details
    Browse the repository at this point in the history

  18. Revert "[Desktop] Trying to fix logo not showing on release build aft… 

    …er login"

This reverts commit aa15927.
    @brunolemos
    brunolemos committed Dec 29, 2018
    Configuration menu
    Copy the full SHA
    af0969f View commit details
    Browse the repository at this point in the history

Commits on Dec 30, 2018

  1. [Desktop] Open window on login 

    Fix for menubar mode
    @brunolemos
    brunolemos committed Dec 30, 2018
    Configuration menu
    Copy the full SHA
    74a6080 View commit details
    Browse the repository at this point in the history

  2. [Desktop] Dev server is hardcoded on package.json, so lets hardcode i… 

    …t here as well
    @brunolemos
    brunolemos committed Dec 30, 2018
    Configuration menu
    Copy the full SHA
    5e8ae9b View commit details
    Browse the repository at this point in the history

  3. Change error background color

    @brunolemos
    brunolemos committed Dec 30, 2018
    Configuration menu
    Copy the full SHA
    3fde008 View commit details
    Browse the repository at this point in the history

  4. [Desktop] Avoid flickering on setPosition and setSize when will maxim… 

    …ize next
    @brunolemos
    brunolemos committed Dec 30, 2018
    Configuration menu
    Copy the full SHA
    f9bd3b6 View commit details
    Browse the repository at this point in the history

  5. [Desktop] Run server sync every time Electron window is focused 

    Just like it already does in normal browsers using the visibility api
    @brunolemos
    brunolemos committed Dec 30, 2018
    Configuration menu
    Copy the full SHA
    940d62f View commit details
    Browse the repository at this point in the history

  6. Add author, description and repository on package.json

    @brunolemos
    brunolemos committed Dec 30, 2018
    Configuration menu
    Copy the full SHA
    6ae5e0b View commit details
    Browse the repository at this point in the history

  7. [Desktop] Add mac app category

    @brunolemos
    brunolemos committed Dec 30, 2018
    Configuration menu
    Copy the full SHA
    c8d9113 View commit details
    Browse the repository at this point in the history

  8. [Desktop] Setup Travis for electron-builder

    @brunolemos
    brunolemos committed Dec 30, 2018
    Configuration menu
    Copy the full SHA
    d783c00 View commit details
    Browse the repository at this point in the history

  9. [Desktop] Enable publish to GitHub

    @brunolemos
    brunolemos committed Dec 30, 2018
    Configuration menu
    Copy the full SHA
    e3e4fe2 View commit details
    Browse the repository at this point in the history

  10. [Desktop] Moved About menu code + Show View on GitHub menu item on Wi… 

    …ndows/Linux as well
    @brunolemos
    brunolemos committed Dec 30, 2018
    Configuration menu
    Copy the full SHA
    3ff61d2 View commit details
    Browse the repository at this point in the history

  11. [Desktop] Setup Auto Updater

    @brunolemos
    brunolemos committed Dec 30, 2018
    Configuration menu
    Copy the full SHA
    8bfd9b0 View commit details
    Browse the repository at this point in the history