Finish Desktop apps #69
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
https://github.com/electron/update-electron-app RequirementsBefore using this module, make sure your Electron app meets these criteria:
|
|
Also regenerated icons for all platforms, now with a gradient and better aligment
Desktop mode is now the default one Desktop mode starts maximized Desktop mode is now frameless Create only one window, reuse between Desktop and Menubar Fix Menu and, by consequence, fix Copy, Paste, Select All, etc Remove empty button from TouchBar Option to make window be always at the center Handle Full Screen Mode Allow showing DevTools on development only Show options on Dock icon, Menu and Tray icon Add menu items to open DevHub on GitHub, Report bug and Send feedback Fix app not reopening after Cmd+W Remove arrow
|
@amorist I had to make lot's of changes because having two BrowserWindow was problematic. Also made some fixes, removed the arrow and made the desktop mode the default one. |
|
Almost ready. #70 is the only one that should require more work. |
Fix problem on Windows without bash shell
|
No idea what's causing this:
I think it has something to do with the |
Required for the window.ipc to work on oauth flow
As recommended by Electron warning
…er login" This reverts commit aa15927.
Fix for menubar mode
Just like it already does in normal browsers using the visibility api
brunolemos
force-pushed
the
desktop
branch
2 times, most recently
from
e87769c
to
351250c
Compare
brunolemos
force-pushed
the
desktop
branch
2 times, most recently
from
2310538
to
b8c4e4f
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #2
Pending tasks before launching the desktop apps. Contributions welcome!
package.jsonversions (Couldn't find package " @devhub/[email protected]" #72, f8a79db)Fix arrow not showingChange arrow color based on current themeChange how the arrow was implemented, do it like Harvest, it seems to do it outside of the main BrowserWindowFix bottom bar label being cut (removing the arrow will fix this)