cleanup: add omitCredentials option + make datasetId optional in ts-sdk

devflowinc · Dec 19, 2024 · dc07d33 · dc07d33
1 parent a7f7919
commit dc07d33
Show file tree

Hide file tree

Showing 9 changed files with 295 additions and 38 deletions.
diff --git a/clients/search-component/src/utils/trieve.ts b/clients/search-component/src/utils/trieve.ts
@@ -290,7 +290,7 @@ export const getAllChunksForGroup = async (
       "/api/chunk_group/{group_id}/{page}",
       "get",
       {
-        datasetId: trieve.datasetId,
+        datasetId: trieve.datasetId as string,
         groupId,
         page,
       }

diff --git a/clients/ts-sdk/src/functions/analytics/index.ts b/clients/ts-sdk/src/functions/analytics/index.ts
@@ -41,16 +41,20 @@ export async function getCTRAnalytics(
   /** @hidden */
   this: TrieveSDK,
   data: CTRAnalytics,
-  signal?: AbortSignal,
+  signal?: AbortSignal
 ) {
+  if (!this.datasetId) {
+    throw new Error("datasetId is required");
+  }
+
   return await this.trieve.fetch(
     "/api/analytics/events/ctr",
     "post",
     {
       data,
       datasetId: this.datasetId,
     },
-    signal,
+    signal
   );
 }
 
@@ -71,16 +75,20 @@ export async function sendCTRAnalytics(
   /** @hidden */
   this: TrieveSDK,
   data: CTRDataRequestBody,
-  signal?: AbortSignal,
+  signal?: AbortSignal
 ) {
+  if (!this.datasetId) {
+    throw new Error("datasetId is required");
+  }
+
   return await this.trieve.fetch(
     "/api/analytics/ctr",
     "put",
     {
       data,
       datasetId: this.datasetId,
     },
-    signal,
+    signal
   );
 }
 
@@ -110,16 +118,20 @@ export async function getRagAnalytics(
   /** @hidden */
   this: TrieveSDK,
   data: RAGAnalytics,
-  signal?: AbortSignal,
+  signal?: AbortSignal
 ) {
+  if (!this.datasetId) {
+    throw new Error("datasetId is required");
+  }
+
   return this.trieve.fetch(
     "/api/analytics/rag",
     "post",
     {
       data,
       datasetId: this.datasetId,
     },
-    signal,
+    signal
   );
 }
 
@@ -148,16 +160,20 @@ export async function getRecommendationAnalytics(
   /** @hidden */
   this: TrieveSDK,
   data: RecommendationAnalytics,
-  signal?: AbortSignal,
+  signal?: AbortSignal
 ) {
+  if (!this.datasetId) {
+    throw new Error("datasetId is required");
+  }
+
   return this.trieve.fetch(
     "/api/analytics/recommendations",
     "post",
     {
       data,
       datasetId: this.datasetId,
     },
-    signal,
+    signal
   );
 }
 
@@ -186,16 +202,20 @@ export async function getSearchAnalytics(
   /** @hidden */
   this: TrieveSDK,
   data: SearchAnalytics,
-  signal?: AbortSignal,
+  signal?: AbortSignal
 ) {
+  if (!this.datasetId) {
+    throw new Error("datasetId is required");
+  }
+
   return this.trieve.fetch(
     "/api/analytics/search",
     "post",
     {
       data,
       datasetId: this.datasetId,
     },
-    signal,
+    signal
   );
 }
 
@@ -221,16 +241,20 @@ export async function getClusterAnalytics(
   /** @hidden */
   this: TrieveSDK,
   data: ClusterAnalytics,
-  signal?: AbortSignal,
+  signal?: AbortSignal
 ) {
+  if (!this.datasetId) {
+    throw new Error("datasetId is required");
+  }
+
   return this.trieve.fetch(
     "/api/analytics/search/cluster",
     "post",
     {
       data,
       datasetId: this.datasetId,
     },
-    signal,
+    signal
   );
 }
 
@@ -249,16 +273,20 @@ export async function rateRagQuery(
   /** @hidden */
   this: TrieveSDK,
   data: RateQueryRequest,
-  signal?: AbortSignal,
+  signal?: AbortSignal
 ) {
+  if (!this.datasetId) {
+    throw new Error("datasetId is required");
+  }
+
   return this.trieve.fetch(
     "/api/analytics/rag",
     "put",
     {
       data,
       datasetId: this.datasetId,
     },
-    signal,
+    signal
   );
 }
 
@@ -277,16 +305,20 @@ export async function rateSearchQuery(
   /** @hidden */
   this: TrieveSDK,
   data: RateQueryRequest,
-  signal?: AbortSignal,
+  signal?: AbortSignal
 ) {
+  if (!this.datasetId) {
+    throw new Error("datasetId is required");
+  }
+
   return this.trieve.fetch(
     "/api/analytics/search",
     "put",
     {
       data,
       datasetId: this.datasetId,
     },
-    signal,
+    signal
   );
 }
 
@@ -305,7 +337,7 @@ export async function getTopDatasets(
   /** @hidden */
   this: TrieveSDK,
   data: GetTopDatasetsRequestBody & { organizationId: string },
-  signal?: AbortSignal,
+  signal?: AbortSignal
 ) {
   return this.trieve.fetch(
     "/api/analytics/top",
@@ -314,7 +346,7 @@ export async function getTopDatasets(
       data,
       organizationId: data.organizationId,
     },
-    signal,
+    signal
   );
 }
 
@@ -341,14 +373,14 @@ export async function getAllAnalyticsEvents(
   /** @hidden */
   this: TrieveSDK,
   data: GetEventsRequestBody,
-  signal?: AbortSignal,
+  signal?: AbortSignal
 ) {
   return await this.trieve.fetch(
     "/api/analytics/events/all",
     "post",
     {
       data,
     },
-    signal,
+    signal
   );
 }