bugfix: ts-sdk default behavior with omitCredentials includes them

devflowinc · Dec 19, 2024 · a7f7919 · a7f7919
1 parent 52b5c00
commit a7f7919
Show file tree

Hide file tree

Showing 6 changed files with 14 additions and 4 deletions.
diff --git a/clients/search-component/package.json b/clients/search-component/package.json
@@ -19,7 +19,7 @@
       "import": "./dist/vanilla/index.js"
     }
   },
-  "version": "0.2.31",
+  "version": "0.2.32",
   "license": "MIT",
   "homepage": "https://github.com/devflowinc/trieve/tree/main/clients/search-component",
   "scripts": {

diff --git a/clients/search-component/src/utils/hooks/modal-context.tsx b/clients/search-component/src/utils/hooks/modal-context.tsx
@@ -95,7 +95,11 @@ export type ModalProps = {
   }[];
   zIndex?: number;
   showFloatingButton?: boolean;
-  floatingButtonPosition?: "top-left" | "top-right" | "bottom-left" | "bottom-right";
+  floatingButtonPosition?:
+    | "top-left"
+    | "top-right"
+    | "bottom-left"
+    | "bottom-right";
 };
 
 const defaultProps = {
@@ -219,6 +223,7 @@ const ModalProvider = ({
     baseUrl: props.baseUrl,
     apiKey: props.apiKey,
     datasetId: props.datasetId,
+    omitCredentials: true,
   });
 
   const search = async (abortController: AbortController) => {

diff --git a/clients/trieve-fern-adapter/src/index.ts b/clients/trieve-fern-adapter/src/index.ts
@@ -322,6 +322,7 @@ export const trieve = new TrieveSDK({
   apiKey: trieveApiKey,
   datasetId: trieveDatasetTrackingId,
   organizationId: trieveOrganizationId,
+  omitCredentials: true,
 });
 
 try {

diff --git a/clients/ts-sdk/package.json b/clients/ts-sdk/package.json
@@ -6,7 +6,7 @@
   "files": [
     "dist"
   ],
-  "version": "0.0.46",
+  "version": "0.0.48",
   "license": "MIT",
   "scripts": {
     "lint": "eslint 'src/**/*.ts'",

diff --git a/clients/ts-sdk/src/fetch-client.ts b/clients/ts-sdk/src/fetch-client.ts
@@ -86,19 +86,22 @@ interface TrieveOpts {
   baseUrl: string;
   debug?: boolean;
   organizationId?: string;
+  omitCredentials?: boolean;
 }
 
 export class TrieveFetchClient {
   apiKey?: string;
   baseUrl: string;
   debug: boolean = false;
   organizationId?: string;
+  omitCredentials?: boolean;
 
   constructor(opts: TrieveOpts) {
     this.apiKey = opts.apiKey;
     this.baseUrl = opts.baseUrl;
     this.debug = opts.debug || false;
     this.organizationId = opts.organizationId;
+    this.omitCredentials = opts.omitCredentials;
   }
 
   async fetch<
@@ -166,7 +169,7 @@ export class TrieveFetchClient {
     }
 
     const response = await fetch(this.baseUrl + updatedPath, {
-      credentials: "omit",
+      credentials: this.omitCredentials ? "omit" : "include",
       method,
       headers: headers,
       body: requestBody ? JSON.stringify(requestBody) : undefined,

diff --git a/frontends/dashboard/src/utils/createCodeSnippets.tsx b/frontends/dashboard/src/utils/createCodeSnippets.tsx
@@ -74,6 +74,7 @@ export const reactSearchComponentRequest = (dataset: string, apiKey: string) =>
   `export const trieve = new TrieveSDK({
   apiKey: "${apiKey}",
   datasetId: "${dataset}",
+  omitCredentials: true,
 });
 
 function MyComponent() {