Skip to content

Conversation

@michael-valdron
Copy link
Member

@michael-valdron michael-valdron commented Jun 9, 2022

Signed-off-by: Michael Valdron [email protected]

Please specify the area for this PR
registry server

What does does this PR do / why we need it:

Changes part of the endpoint's slug from starterProjects/<starterProjectName> to starter-projects/<starterProjectName> to better follow URL naming standards. This change also unblocks devfile/api#781.

Effects previous issues:

Which issue(s) this PR fixes:

Fixes #?

fixes devfile/api#865

PR acceptance criteria:

  • Test (WIP)

Documentation (WIP)

How to test changes / Special notes to the reviewer:

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Jun 9, 2022
@openshift-ci
Copy link

openshift-ci bot commented Jun 9, 2022

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: michael-valdron, schultzp2020
To complete the pull request process, please assign maysunfaisal after the PR has been reviewed.
You can assign the PR to them by writing /assign @maysunfaisal in a comment when ready.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@michael-valdron michael-valdron merged commit 3861d54 into devfile:main Jun 9, 2022
@michael-valdron michael-valdron deleted the slug-change branch June 9, 2022 20:08
@michael-valdron michael-valdron mentioned this pull request Jul 12, 2022
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

lgtm Indicates that a PR is ready to be merged.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Minor Change to slug of the download-starter-project endpoint

2 participants