Add offline support for starter projects #118
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
michael-valdron
force-pushed
the
offline-support
branch
from
226b751 to
f1a2a7a
Compare
johnmcollier
requested changes
Jun 9, 2022
|
Will need to be rebased for incoming changes in PR #119 |
Signed-off-by: Michael Valdron <[email protected]>
- Removed duplicate import of indexSchema and fixed line effecting it - Error pulling from OCI Registry now returns error 500 and gets reported Signed-off-by: Michael Valdron <[email protected]>
Signed-off-by: Michael Valdron <[email protected]>
Signed-off-by: Michael Valdron <[email protected]>
Signed-off-by: Michael Valdron <[email protected]>
Signed-off-by: Michael Valdron <[email protected]>
- makeVersionMap function created - versionMap creation source in fetchDevfile replaced by makeVersionMap invoke - fetchDevfile invoke under download starter projects endpoint now returns devfile index schema - version injection in offline stack path fixed Signed-off-by: Michael Valdron <[email protected]>
… devfiles. Signed-off-by: Michael Valdron <[email protected]>
… added. Signed-off-by: Michael Valdron <[email protected]>
Signed-off-by: Michael Valdron <[email protected]>
…ead of a constant. Signed-off-by: Michael Valdron <[email protected]>
Signed-off-by: Michael Valdron <[email protected]>
michael-valdron
force-pushed
the
offline-support
branch
from
f1a2a7a to
1dbcfbe
Compare
|
rebased on PR #119 changes |
…(branches) and with a subdir defined. Signed-off-by: Michael Valdron <[email protected]>
Signed-off-by: Michael Valdron <[email protected]>
…roject is invalid added. Signed-off-by: Michael Valdron <[email protected]>
michael-valdron
force-pushed
the
offline-support
branch
2 times, most recently
from
266c6eb to
4cb7c9b
Compare
…akeVersionMap function. Signed-off-by: Michael Valdron <[email protected]>
michael-valdron
force-pushed
the
offline-support
branch
from
4cb7c9b to
33639be
Compare
Signed-off-by: Michael Valdron <[email protected]>
michael-valdron
force-pushed
the
offline-support
branch
from
9962eed to
3439b2f
Compare
Signed-off-by: Michael Valdron <[email protected]>
Signed-off-by: Michael Valdron <[email protected]>
johnmcollier
approved these changes
Jun 17, 2022
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: johnmcollier, michael-valdron The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
openshift-ci
bot
added
the
approved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Michael Valdron [email protected]
Please specify the area for this PR
registry server
What does does this PR do / why we need it:
Provides the use of offline starter projects using the
download-starter-projectsendpoint. There are also fixes to unrelated warnings in theendpoint.gosource file.Changes
download-starter-projectsendpointdownload-starter-projectsendpoint that tests offline downloadingbuild-tools/dl_starter_projects.shscript for downloading starter project for offline testing during CI buildgo-starter-offlinestarter project added to go stack as an offline copy ofgo-starterMakeVersionMaputil function inutil.gowith testing underutil_test.goindexSchemaimportspullStackFromRegistryprocedureWhich issue(s) this PR fixes:
Fixes #?
fixes devfile/api#851
PR acceptance criteria:
Documentation (WIP)
How to test changes / Special notes to the reviewer: