Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[ Refactor ] Add customizable TOTP_NOT_FOUND error message and remove hostUrl from MagicLinkGenerationOptions. #34

Merged
merged 3 commits into from
Dec 20, 2023
Merged

[ Refactor ] Add customizable TOTP_NOT_FOUND error message and remove hostUrl from MagicLinkGenerationOptions. #34

merged 3 commits into from
Dec 20, 2023

Conversation

mw10013
Copy link
Collaborator

@mw10013 mw10013 commented Dec 20, 2023

Closes #32, #33

If this PR is accepted, please hold off on releasing since I'd like to propose a change with expireAt which I create an issue for.

@mw10013 mw10013 requested a review from dev-xo December 20, 2023 17:43
dev-xo
dev-xo approved these changes Dec 20, 2023
View reviewed changes
Copy link
Owner

@dev-xo dev-xo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks fantastic to me, @mw10013! I would prefer not to combine Issues like #32 and #33 and instead create separate PRs, but it's okay.

Also, only do this if you have the time! I do not want to make you spend more time on this than you should!

@dev-xo dev-xo merged commit 3c65899 into dev-xo:main Dec 20, 2023
4 checks passed
@mw10013 mw10013 deleted the 32-33 branch December 27, 2023 19:59
@dev-xo dev-xo changed the title Make TOTP_NOT_FOUND error message customizable and Remove hostUrl from MagicLinkGenerationOptions [ Refactor ] Add customizable TOTP_NOT_FOUND error message and remove hostUrl from MagicLinkGenerationOptions. Dec 28, 2023
@mw10013 mw10013 mentioned this pull request Jan 1, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dev-xo dev-xo dev-xo approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[ Feat ] Make TOTP_NOT_FOUND error message customizable
2 participants
@mw10013 @dev-xo